VM Migration Can't Set Quota

[Smithx10]

During a Migration we saw this. I'm not 100% sure if the operator resized these instances outside of the inst resize, or went higher than the "billing id". I believe during this failure the cancel chain didn't walk back the changes and booted this one up with quota=none.

        {
          "type": "progress",
          "message": "switching instances",
          "phase": "switch",
          "state": "failed",
          "started_timestamp": "2023-03-18T04:32:43.408Z",
          "current_progress": 1,
          "total_progress": 100,
          "job_uuid": "9448d587-366a-4dd1-968d-145f8733f3b3",
          "finished_timestamp": "2023-03-18T04:32:56.232Z",
          "error": "zfs set failure: Command failed: /usr/sbin/zfs set quota=88992907263 zones/3be3db4b-9a22-40cb-8b02-85f9b0927890\ncannot set property for 'zones/3be3db4b-9a22-40cb-8b02-85f9b0927890': size is less than current used or reserved space\n",
          "disallowRetry": true
        }

[danmcd]

"size is less than current used or reserved space" From libzfs...

        case ENOSPC:
                /*
                 * For quotas and reservations, ENOSPC indicates
                 * something different; setting a quota or reservation
                 * doesn't use any disk space.
                 */
                switch (prop) { 
                case ZFS_PROP_QUOTA:
                case ZFS_PROP_REFQUOTA:
                        zfs_error_aux(hdl, dgettext(TEXT_DOMAIN,
                            "size is less than current used or "
                            "reserved space")); 
                        (void) zfs_error(hdl, EZFS_PROPSPACE, errbuf);
                        break;

There may be some interaction with refreservation and other dataset properties.

[bahamat]

I think this was fixed as part of db7971d3 which is included in release-20231130 and later. @Smithx10 Can you test this on a platform with that change?