Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - Transitions on InfoBar #23

Open
TheOnlyTails opened this issue Feb 2, 2022 · 6 comments
Open

Feature Request - Transitions on InfoBar #23

TheOnlyTails opened this issue Feb 2, 2022 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@TheOnlyTails
Copy link
Collaborator

Right now, <InfoBar> components, which are supposed to display helpful notifications/information, have no loading animation, which could be nice to have.

I'm thinking of something like a quick fly transition.

@TheOnlyTails TheOnlyTails added the enhancement New feature or request label Feb 2, 2022
@TheOnlyTails TheOnlyTails self-assigned this Feb 2, 2022
@Tropix126
Copy link
Owner

I think this should be handled in userland rather than have fluent-svelte take opinions on this. WinUI adds no transitions, so i'm somewhat against shipping this by default.

@Tropix126
Copy link
Owner

A simple way around this would either to add an API for exposing transitions to components (which is something i've been considering), or just using a wrapper element with the transition.

@TheOnlyTails
Copy link
Collaborator Author

TheOnlyTails commented Feb 2, 2022

I think this should be handled in userland rather than have fluent-svelte take opinions on this.

The main problem is that Svelte prohibits using transitions on components;
I think that Fluent Svelte should match the WinUI spec completely, by default. Extra configuration options that deviate slightly from the original spec shouldn't be completely prohibited.

@Tropix126
Copy link
Owner

Tropix126 commented Feb 2, 2022

See my comment above about forwarding transitions. It's possible, similar to the actions array method, but would require a fair amount of boilerplate internally. I'm hoping that svelte will eventually implement a method of doing this natively. For now, a wrapper element should do the trick until ive made a decision.

@TheOnlyTails
Copy link
Collaborator Author

What about a transition tuple prop? first item is the actual function, 2nd is the transition props. that way it's completely customizable

@Tropix126
Copy link
Owner

What about a transition tuple prop? first item is the actual function, 2nd is the transition props. that way it's completely customizable

This is what I have in mind more or less, and it's completely possible. The thing is that for the sake of consistency i'd need to add this to every existing component. At that point I might as well add action forwarding as well using the same technique. I'm still undecided if this is a good idea, though, but if it's clear that the svelte maintainers don't like sveltejs/rfcs#60 i'll get around to adding it.

@Tropix126 Tropix126 changed the title Feature Request - Loading transition for InfoBar Feature Request - Transitions on InfoBar Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants