Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ember-decorators #214

Open
rogatty opened this issue Jul 5, 2018 · 5 comments
Open

Add support for ember-decorators #214

rogatty opened this issue Jul 5, 2018 · 5 comments

Comments

@rogatty
Copy link

rogatty commented Jul 5, 2018

If you want to use JS native classes you also need to use http://ember-decorators.github.io/ember-decorators/latest/docs. Currently, this plugin doesn't understand what the decorators mean. When using the @service decorator, there is no lightning bolt icon linking to the service, unlike when using serviceName: service().

screenshot

@Turbo87
Copy link
Owner

Turbo87 commented Jul 5, 2018

@rogatty that would be nice! can you work on adding support for that?

@rogatty
Copy link
Author

rogatty commented Jul 5, 2018

I have no experience with Kotlin or IntelliJ plugins but I'll try to poke it with a stick if I find the time for it.
I opened this issue mostly to let you know that there is a new Ember feature that will be more and more popular as people migrate to the native classes. If I don't get to it first, I hope the hundreds of 👍 👍 👍 on the original post will get your attention 😉

@Turbo87
Copy link
Owner

Turbo87 commented Jul 5, 2018

there is a new Ember feature

it's not an Ember feature yet though, only an addon that promotes an unstable ES proposal. once this gets into mainstream Ember I could have a look, but for now it's not high on my todo list 😉

@robclancy
Copy link

Octane is almost done and this addon is very outdated compared to it. This is probably the main feature that is needed though.

@Turbo87
Copy link
Owner

Turbo87 commented Nov 10, 2019

@robclancy I agree, would be great if someone could find the time to work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants