Add min and max block to true-fantom/math.js #2202
Open
+31
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr: change existing extension
|
!format |
Comment on lines
+641
to
+647
| min_or_max_block(args) { | ||
| if (args.MIN_OR_MAX === "min") { | ||
| return Math.min(args.A, args.B); | ||
| } else { | ||
| return Math.max(args.A, args.B); | ||
| } | ||
| } |
There was a problem hiding this comment.
Just do this:
Suggested change
| min_or_max_block(args) { | |
| if (args.MIN_OR_MAX === "min") { | |
| return Math.min(args.A, args.B); | |
| } else { | |
| return Math.max(args.A, args.B); | |
| } | |
| } | |
| min_or_max_block(args) { | |
| return Math[args.MIN_OR_MAX](args.A, args.B); | |
| } |
oh wait just realized accept reporters was true never mind it won't work
This means you should use Scratch.Cast.toString()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not only do we need this, but I literally don't know an official extension in the gallery that has this block.