Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to roll nodes at a specific time range #115

Open
zaafar opened this issue May 31, 2023 · 1 comment
Open

Ability to roll nodes at a specific time range #115

zaafar opened this issue May 31, 2023 · 1 comment

Comments

@zaafar
Copy link

zaafar commented May 31, 2023

Describe the feature request

It will allow us to define an off-hour time range and only roll nodes during that time.
e.g. HANDLER_START_HOUR, HANDLER_STOP_HOUR

== from HANDLER_START_HOUR to HANDLER_STOP_HOUR ==
it should do what it currently does

== from HANDLER_STOP_HOUR to HANDLER_START_HOUR ==
it should not cordon OR drain any node

Why do you personally want this feature to be implemented?

I don't have to wake up at night to merge my PR and/OR trigger the pipeline to change the template and kick off asg-rolling-update-handler :)

How long have you been using this project?

6 months

Additional information

This is an amazing project!!! Thank you!!!

@TwiN
Copy link
Owner

TwiN commented Jun 6, 2023

It's not a bad idea, but you could use something like a CronJob with activeDeadlineSeconds configured instead if you don't want the application to run outside of business hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants