Skip to content

Give Love to JSONPath Implementation #1022

@meerumschlungen

Description

@meerumschlungen

I'd like to tackle the comment in https://github.com/TwiN/gatus/blob/master/jsonpath/jsonpath.go#L10
Eval is a half-baked json path implementation that needs some love

Rough Plan:

  1. Max out test coverage for the current implementation
  2. Properly re-implement the jsonpath package ensuring future extendability and maintainability, ensuring the tests from 1. pass for the new implementation
  3. Max out test coverage for the new implementation
  4. Run new tests from 3. against the old implementation to ensure backward compatibility
  5. Check out benchmarks
  6. Be happy (hopefully)

I do not intend to change or add functionality in the first place with the reimplementation but am eager to do so in the future since I could use it well myself.
This should provide a solid foundation for solving e.g. #335 or #225.

@TwiN Please confirm nobody's working on this already.
Thank you for your great work so far!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions