feat: support new tls.ca-file field #1124
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TwiN
requested changes
Aug 2, 2025
README.md
Outdated
| tls: | ||
| certificate-file: /path/to/user_cert.pem | ||
| private-key-file: /path/to/user_key.pem | ||
| ca-file: /path/to/root-ca.pem |
Owner
There was a problem hiding this comment.
Could you specify in the table that ca-file is optional for non-self-signed certificate authorities, and a similar comment in the yaml example next to ca-file: /path/to/root-ca.pem?
For verbosity, I want devs to keep their configuration as simple as possible, and by adding these comments, I hope it'll make it more clear that this isn't required unless it's an unrecognized/self-signed CA
Author
There was a problem hiding this comment.
I've updated the readme with the comment next to the yaml example & the table. does this looks good to you?
|
👍 @TwiN , please accept this PR—this feature is urgently needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We have a use case where we want to monitor self-signed cert served from MTLS endpoint. Currently, Gatus will show error
tls: failed to verify certificate: x509: certificate signed by unknown authorityWith this change, I'm able to specify my own CA and the check is passing.
Checklist
README.md, if applicable.