refactor(ui): Cleanup template option handling #1430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PythonGermany
force-pushed
the
improve-ui-config-handling
branch
from
7e2cc8b to
19352e3
Compare
PythonGermany
commented
Dec 10, 2025
PythonGermany
force-pushed
the
improve-ui-config-handling
branch
from
7068b86 to
4590544
Compare
2 tasks
PythonGermany
commented
Dec 21, 2025
| "env": { | ||
| "node": true | ||
| "node": true, | ||
| "es2024": true |
Contributor
Author
There was a problem hiding this comment.
I'm not sure about this yet. Without this eslint complains about globalThis not being defined. But I still haven't understood the impact of the change and which version to choose.
Contributor
Author
|
/regenerate-static-assets |
|
👋 PythonGermany, seems as if you have not write/admin permissions in this repo, permissions: read |
Contributor
Author
|
@TwiN Just as I had worried about, the rights for me are obviously not the same as in my fork which prevents me from running the command, even as author of the PR 😞 Can you test if you can trigger it in this PR to commit to the branch? We might have to whitelist the author of this PR using their username after all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the development environment the UI config placeholders are not replaced.
Improves how configs which have template placeholders as default value (replaced at go application startup by actual config value, as far as I know) are initialized and accessed in the web app.
Checklist
README.md, if applicable.