Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Response time includes DNS request time #49

Open
Exagone313 opened this issue Nov 22, 2020 · 0 comments · May be fixed by #526
Open

Response time includes DNS request time #49

Exagone313 opened this issue Nov 22, 2020 · 0 comments · May be fixed by #526
Labels
bug Something isn't working

Comments

@Exagone313
Copy link
Contributor

When performing an HTTP request, Gatus computes the duration for the whole HTTP client library call, which includes the DNS request time.

My proposal is to make the response time be only the HTTP response time (+- TLS?).

This can probably be implemented using Go's HTTP Tracing feature.
@TwiN TwiN added the bug Something isn't working label Nov 23, 2020
@pathcl pathcl mentioned this issue Feb 28, 2022
Open
Exagone313 added a commit to Exagone313/gatus that referenced this issue Jul 16, 2023
@Exagone313
feat(core): do not include DNS query time in HTTP response time
bfe25f7 
Fix TwiN#49
@Exagone313 Exagone313 linked a pull request Jul 16, 2023 that will close this issue
Draft
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(core): do not include DNS query time in HTTP response time Exagone313/gatus
2 participants
@Exagone313 @TwiN