-
Notifications
You must be signed in to change notification settings - Fork 164
Tyk Governance - new content for v0.2 #6759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
✅ PS. Add to the end of url /docs/nightly
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ PS. Add to the end of url /docs/nightly
To edit notification comments on pull requests, go to your Netlify project configuration. |
Code Review: New Content for Tyk Governance v0.2SummaryThis PR adds comprehensive documentation for Tyk Governance v0.2, focusing on three new features: Agent Management, API Evaluation, and Governance Rulesets. It also updates the installation guide with UI and scheduled sync instructions, enhances the overview with shift-left governance details, and updates the navigation menu to include the new documentation pages. Overall AssessmentThe documentation is well-structured, comprehensive, and provides clear guidance for users. The content follows a consistent format across all pages with appropriate sections for overview, quick start, configuration options, use cases, best practices, FAQs, and troubleshooting. The documentation effectively communicates both conceptual information and practical implementation details. Detailed ReviewNew Content1. Agent Management (
|
Co-authored-by: bsten-tyk <[email protected]>
Co-authored-by: bsten-tyk <[email protected]>
Co-authored-by: bsten-tyk <[email protected]>
1. **Agent Configuration File (Agent-side scheduling)** | ||
Configure the `syncSchedule` section in the agent's configuration file: | ||
|
||
```yaml | ||
# Agent configuration with scheduled sync | ||
syncSchedule: | ||
enabled: true | ||
intervalMinutes: 60 # Sync every hour | ||
``` | ||
|
||
With this configuration: | ||
- The agent will independently initiate synchronization every `intervalMinutes` | ||
- This happens regardless of any schedules configured on the Governance Hub | ||
- It's a "pull" model where the agent decides when to sync | ||
- Minimum interval is 5 minutes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sredxny correct me if I am wrong, but sync schedule is set on governance dashboard side; not agent side. So, there is no syncSchedule
configurations on Agent side
### Scheduled Synchronization Variables (New in v0.2) | ||
| Environment Variable | Description | Default Value | | ||
|---------------------|-------------|---------------| | ||
| `TYK_AGENT_SYNCSCHEDULE_ENABLED` | Enable scheduled synchronization | `false` | | ||
| `TYK_AGENT_SYNCSCHEDULE_INTERVALMINUTES` | Interval in minutes between syncs (minimum 5) | `60` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sredxny do we have this option? I guess there are no such configurations
Co-authored-by: bsten-tyk <[email protected]>
Co-authored-by: bsten-tyk <[email protected]>
User description
Contributor checklist
New Contributors
master
PR Type
Documentation
Description
Adds comprehensive documentation for Agent Management, API Evaluation, and Governance Rulesets
Updates installation guide with UI and scheduled sync instructions for agents
Enhances overview with shift-left governance and scheduled sync details
Updates navigation menu to include new governance documentation pages
Changes diagram
Changes walkthrough 📝
agent-management.md
Add comprehensive Agent Management documentation for v0.2
tyk-docs/content/tyk-governance/agent-management.md
FAQs, and troubleshooting
api-evaluation.md
Add API Evaluation documentation and usage examples
tyk-docs/content/tyk-governance/api-evaluation.md
integration with CI/CD
governance-rulesets.md
Add Governance Rulesets documentation and examples
tyk-docs/content/tyk-governance/governance-rulesets.md
installation.md
Update installation guide for agent UI and scheduled sync
tyk-docs/content/tyk-governance/installation.md
generation
overview.md
Update overview with shift-left and scheduled sync
tyk-docs/content/tyk-governance/overview.md
menu.yaml
Update navigation menu for new governance docs
tyk-docs/data/menu.yaml
Agent Management