Skip to content
This repository has been archived by the owner on Jan 22, 2021. It is now read-only.

Fix and modernise the controller Dockerfile #42

Open
3 of 4 tasks
excieve opened this issue Jul 1, 2020 · 0 comments
Open
3 of 4 tasks

Fix and modernise the controller Dockerfile #42

excieve opened this issue Jul 1, 2020 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@excieve
Copy link
Member

excieve commented Jul 1, 2020

Currently the controller Dockerfile is referencing some goproxy directory on the image that doesn't even exist:

CMD ["/opt/goproxy/tyk-k8s", "start"]

The binary is installed in the /opt/tyk-k8s directory instead.

Moreover, the Dockerfile itself could use some love:

  • Move to multi-stage builds
  • Use a smaller base image (e.g. Debian slim or Alpine).
  • Use an entrypoint
  • Run the process as a non-root user
@excieve excieve added enhancement New feature or request good first issue Good for newcomers labels Jul 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant