Skip to content

Change the dark-mode hyperlink colour for a higher contrast ratio and make all hyperlink underlines more visible #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
samcunliffe opened this issue May 23, 2025 · 2 comments · May be fixed by #545
Open

Change the dark-mode hyperlink colour for a higher contrast ratio and make all hyperlink underlines more visible #535

samcunliffe opened this issue May 23, 2025 · 2 comments · May be fixed by #545
Labels
accessibility Something relating to the ease of accessibility (alt-text, colour choices, language, etc) enhancement New feature or request investigate Some investigation is needed website Related to https://github-pages.arc.ucl.ac.uk/python-tooling

Comments

@samcunliffe
Copy link
Member

samcunliffe commented May 23, 2025 •
edited
Loading

See parent issue for more explaination. But the releavent part of James' email:

As there are quite a lot of hyperlinks on all pages, it would be great if their dark-mode colour could be lightened until they have a contrast ratio of 4.5:1 or more against both the background colour (#27262b; current ratio is 4.13:1) and the slightly lighter code text background (#31343f; current ratio is 3.41:1); a contrast checker can be used to find the best colour options. Increasing the visibility of the links' underline would also really help, to provide an additional visual means to know that a link is a link, as it's currently nearly invisible in both modes.

Definition of done

Dark mode link colour contrasts more with the background.
Hyperlink underline style is thicker.

Ideas dump

PR to upstream theme? Hack the theme ourselves? Change theme completely (but then we risk breaking more than we fix)
@samcunliffe samcunliffe added enhancement New feature or request website Related to https://github-pages.arc.ucl.ac.uk/python-tooling accessibility Something relating to the ease of accessibility (alt-text, colour choices, language, etc) labels May 23, 2025
@samcunliffe samcunliffe mentioned this issue May 23, 2025
Closed
@samcunliffe samcunliffe changed the title change the dark-mode hyperlink colour for a higher contrast ratio and make all hyperlink underlines more visible Change the dark-mode hyperlink colour for a higher contrast ratio and make all hyperlink underlines more visible May 23, 2025
@samcunliffe samcunliffe mentioned this issue May 23, 2025
Open
@samcunliffe
Copy link
Member Author

Looks like

might be related.

@samcunliffe samcunliffe added the investigate Some investigation is needed label May 23, 2025
@samcunliffe samcunliffe mentioned this issue Jun 3, 2025
Merged
@cuteshaun
Copy link
Contributor

Thanks for the detailed breakdown! I’ve picked this up

@cuteshaun cuteshaun linked a pull request Jun 7, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accessibility Something relating to the ease of accessibility (alt-text, colour choices, language, etc) enhancement New feature or request investigate Some investigation is needed website Related to https://github-pages.arc.ucl.ac.uk/python-tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: improve contrast for all links, button and label text cuteshaun/python-tooling
2 participants
@samcunliffe @cuteshaun