Conversation
Closed
Collaborator
Author
|
@marghe-molaro ready for review |
Collaborator
|
Thanks @mmsuarezcosta, This looks good to me, I think all hardcoded parameters have been removed so updating this in the sheet file. All other labelling decisions - specifically which parameters classify as universals and which don't - will need to be reviewed by the module developer. @EvaJanouskova , ready for you to review |
Collaborator
|
@tbhallett ready for your review |
tbhallett
approved these changes
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parameters
Local v Universal
effectiveness_of_complementary_feeding_education_in_stunting_reduction: marked as local because believe education is location-specificeffectiveness_of_food_supplementation_in_stunting_reduction: marked as universal because believe this can be compared to a 'treatment'or_stunting_maleas universal.rr_stunting_per_diarrhoeal_episode. I would argue that this one should also be local as it is in the parameter category of local incidence rate. However, there may be an argument for this variable and others (e.g.rr_stunting_preterm_and_AGAandrr_stunting_SGA_and_pretermto be deemed as universal)Hard coding
Keep age group values hard coded (e.g. 1 to 2, 2 to 3, ...). Only parameterized the max age of stunting (age 5)
Files