Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write unit tests for spatial_transformations.py #5

Open
Chad-Peterson opened this issue Nov 23, 2022 · 2 comments
Open

Write unit tests for spatial_transformations.py #5

Chad-Peterson opened this issue Nov 23, 2022 · 2 comments
Assignees
Labels
Summer REU Task Tasks selected for summer REUs. testing Things that need tests written, etc.

Comments

@Chad-Peterson
Copy link
Collaborator

Right now spatial_transformations.py contains two functions: translate and rotate_about_point. These calculations need unit tests.

Reminder: Please include an illustration of each test case in the associated test folder. This could be a hand-drawn picture or a screenshot of a PowerPoint slide. I'll figure out a standard format later.

@Chad-Peterson Chad-Peterson added this to the SPI2py Alpha Release milestone Nov 23, 2022
@Chad-Peterson
Copy link
Collaborator Author

Clarification: For now, please attach any work you do by hand as a PNG/JPG/PDF/PPT when you respond to this issue. In the future, when we create actual visualization, we will refer back to this chat.

@Chad-Peterson Chad-Peterson added the testing Things that need tests written, etc. label Nov 30, 2022
@Chad-Peterson Chad-Peterson self-assigned this Jan 7, 2023
@Chad-Peterson
Copy link
Collaborator Author

Chad-Peterson commented Mar 18, 2023

TODO: Confirm if finite differencing the rotation angles returns the object to its original position or if I need to invert the rotation matrix somehow (inverting is easy, but knowing when to invert requires logic).

Currently, to avoid components drifting from FD, we avoid this problem by only calculating the FD positions and not actually setting the component position with each step.

@Chad-Peterson Chad-Peterson added the Summer REU Task Tasks selected for summer REUs. label Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Summer REU Task Tasks selected for summer REUs. testing Things that need tests written, etc.
Projects
None yet
Development

No branches or pull requests

1 participant