Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to handle inter-toolbox dependencies? #379

Open
dankessler opened this issue Nov 2, 2015 · 1 comment
Open

How to handle inter-toolbox dependencies? #379

dankessler opened this issue Nov 2, 2015 · 1 comment
Assignees

Comments

@dankessler
Copy link
Member

Issue #378 brought up some discussion of inter-toolbox dependencies, so I'm opening this issue thread to hash out best practices for an inter-toolbox dependency workflow.

@dankessler
Copy link
Member Author

I don't think I've actually addressed dependency in the wiki, so here's how I would handle Robert's example workflow (my approach is not necessarily the correct one, just laying it out for discussion purposes).

Scenario: Currently, spm8Batch uses spm8 R4667. I want to update spm8Batch to use spm8 R6313. Of course, I need to actually have R6313 available for this to make sense.

Let's start out by assuming that we don't have alpha/beta channels (this will simplify my notation) and that all channels currently reflect the stable & released version of their toolbox.

  1. checkout a new branch based on core called core/add_spm8_R6313
  2. add spm8_R6313 to appropriate folder and commit
  3. checkout a new branch based on spm8Batch called spm8Batch/support_spm8_R6313
  4. merge core/add_spm8_R6313 into my current branch (spm8Batch/support_spm8_R6313)
  5. make changes to spm8Batch so that it points to R6313 (now available via the merge)
  6. submit pull request A: core/add_spm8_R6313 ->into-> universe/core
  7. submit pull request B: spm8Batch/support_spm8_R6313 ->into->universe/spm8Batch

The two pull requests can be independently reviewed. Adding spm8_R6313 is presumably straightforward, but for the sake of discourse, let's assume that somehow there's a problem that is identified while reviewing pull request A that necessitates some changes to core/add_spm8_R6313. We simply then merge core/add_spm8_R6313 ->into->spm8Batch/support_spm8_R6313 again and those fixes are now incorporated.

@dankessler dankessler self-assigned this Nov 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant