Skip to content

Commit 0ea9ae8

Browse files
authored
Prefer require_relative for internal requires (activeadmin#939)
`require_relative` is preferred over `require` for files within the same project because it uses paths relative to the current file, making code more portable and less dependent on the load path. This change updates internal requires to use `require_relative` for consistency, performance, and improved portability. Ref: - activeadmin/arbre#622
1 parent 9cabeb6 commit 0ea9ae8

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

lib/inherited_resources.rb

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,10 @@
33
# This is here because responders don't require it.
44
require 'rails/engine'
55
require 'responders'
6-
require 'inherited_resources/engine'
7-
require 'inherited_resources/blank_slate'
8-
require 'inherited_resources/responder'
6+
7+
require_relative 'inherited_resources/engine'
8+
require_relative 'inherited_resources/blank_slate'
9+
require_relative 'inherited_resources/responder'
910

1011
module InheritedResources
1112
ACTIONS = [ :index, :show, :new, :edit, :create, :update, :destroy ] unless self.const_defined?(:ACTIONS)

lib/inherited_resources/base_helpers.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# frozen_string_literal: true
22

33
# Whenever base is required load the dumb responder since it's used inside actions.
4-
require 'inherited_resources/blank_slate'
4+
require_relative 'blank_slate'
55

66
module InheritedResources
77
# Base helpers for InheritedResource work. Some methods here can be overwritten

0 commit comments

Comments
 (0)