Update DisplayInfoOnLCD.py #18774

GregValiant · 2024-03-31T12:00:08Z

Bug fix for "remaining_time".
Affected M118 and M73_time
Bug was pointed out in #18766

Description

This repairs a problem with M118 lines being added if "remaining_time" was not selected. The bug affected M118 and M73_time insertions.
There was a request to add the "A" and "P" parameters to the M118 lines as they might be required by Octoprint.
Adding M117 is now an option.

This fixes... OR This improves... -->

Type of change

[ X] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Cura 5.7beta and 4.13.1

Test Configuration:

Operating System: Win 10 Pro

Checklist:

[ X] My code follows the style guidelines of this project as described in UltiMaker Meta and Cura QML best practices
[X ] I have read the Contribution guide
[ X] I have commented my code, particularly in hard-to-understand areas
[ X] I have uploaded any files required to test this change

GregValiant · 2024-04-03T13:24:22Z

Most of these changes were requested by #18766 while other are because I'm unable to keep my fingers out of it.
The changes have missed 5.7.0 so I will move it back to active when I eventually quit fooling with it.

Bug fix for "remaining_time". Affected M118 and M73_time Update DisplayInfoOnLCD.py Add options for Time-to-pause to include Filament Change. Update DisplayInfoOnLCD.py Make M117 optional. Combine M73 R and M73 P lines into a single line. Add A and P parameters for M118 lines. Update DisplayInfoOnLCD A TouchUp. Update DisplayInfoOnLCD.py TouchUp Update DisplayInfoOnLCD.py TuneUp

Should not have been included.

GregValiant · 2024-04-07T13:06:50Z

I see no reason why Remco and Casper have to be the only ones horrified by my coding style.

plugins/PostProcessingPlugin/scripts/DisplayInfoOnLCD.py

HellAholic · 2024-04-08T07:00:55Z

I see no reason why Remco and Casper have to be the only ones horrified by my coding style.

Did a quick check to share the horror :P But I'm not familiar enough with the code to make a full review on it.

GregValiant · 2024-04-08T10:43:31Z

Thanks for looking anyway.
I'll make changes locally until a full review. Maybe I can get by with just a single additional commit.

Revised the M118 lines and insertion point in the gcode. Revised M117 same. Added nozzle size and filament type to data[0]

github-actions · 2024-12-30T21:44:52Z

Test Results

23 953 tests ±0 23 951 ✅ ±0 47s ⏱️ -1s
1 suites ±0 2 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 3ad2c1b. ± Comparison against base commit 4e04d06.

♻️ This comment has been updated with latest results.

Added "global_stack" variable.

Bug fix.

Update. Remove vestigial line of code at line 530.

Added a condition so the pause_cmd setting box is hidden unless the 'display_option' == "display_progress".

Split functions from Execute. Added function "Add Settings" so it also works with the "filename_layer" option.

Changed the fialment type 'get' from: 'getProperty' to 'material.getMetaDataEntry'

plugins/PostProcessingPlugin/scripts/DisplayInfoOnLCD.py

Added the "time to pause" to the user message. Update DisplayInfoOnLCD.py update

plugins/PostProcessingPlugin/scripts/DisplayInfoOnLCD.py

HellAholic · 2025-03-23T09:44:07Z

Strings like "M118 ", "M117 ", and "M73" are repeated through the code. You could define these as constants at the top of the script for easier maintenance. For example:

M117_COMMAND = "M117 "
M118_COMMAND = "M118 "
M73_COMMAND = "M73"

plugins/PostProcessingPlugin/scripts/DisplayInfoOnLCD.py

Fixed the m118_str/m118_text confusion.

Requested changes

Minor changes to the statistics added to the beginning of the gcode.

Changes to the print statistics entered into the gcode.

GregValiant · 2025-04-14T13:08:12Z

Per a suggestion in #20509 I added the profile name to the other settings being inserted at the beginning of the gcode.

Add the 'Quality Name' to the gcode with the other settings. Update DisplayInfoOnLCD.py Touchups. Update DisplayInfoOnLCD.py Minor change

Made some changes to the print stats that are added to the gcode. Update DisplayInfoOnLCD.py

GregValiant · 2025-05-22T16:24:49Z

After working on PrintSkew and seeing that different printer names can be involved I changed this script to alter the Cura inserted "TARGET_MACHINE.NAME" line.
Commit 17 example of the new line:
;TARGET_MACHINE.NAME:Creality CR-10 / BMG CR-10
So it would become "Printer_Model / Users_Printer_Name"

It turns out that some firmware doesn't like colons within M118 commands.

GregValiant · 2025-07-01T01:39:41Z

@HellAholic
I remembered seeing a PR for "Electricity Cost" (#14952 ). DisplayInfoOnLCD was already adding some stats so I threw in "Electricity Cost" as well.
If you approve this then I think 14952 can be closed.

;FLAVOR:Marlin
;TIME:5507
;Cura Time Estimate: 1hr 31min 
;Extruder 1 (T0)
;  Filament used: 8.15m
;  Filament Type: PLA
;  Filament Dia.: 1.75mm
;  Nozzle Size  : 0.6mm
;  Print Temp.  : 205.0°
;  Bed Temp.    : 50°
;Electric Cost: $0.07
;Layer height: 0.25
;Initial Layer Height: 0.25
;Base Quality Name  : 'Standard Quality'
;Custom Quality Name: 'GV PLA 75'
;Model List: ['GV_CalibrationShape V2.stl']

Add "Electricity Cost" to the statistics added to the gcode. Update DisplayInfoOnLCD.py Formatting changes for layer heights

HellAholic · 2025-07-02T11:02:34Z

I'll take a look. 👍

github-actions bot added the PR: Community Contribution 👑 Community Contribution PR's label Mar 31, 2024

GregValiant requested review from casperlamboo and rburema March 31, 2024 12:01

GregValiant mentioned this pull request Mar 31, 2024

Display Info on LCD #18766

Open

GregValiant added PR: BooBoos 😇 Suggestions for Typos, like the NoMesh or there is a suggested refactor PR: Post Processing ➕ Like adding beeps, more tunability or different Gcode pause at heights labels Mar 31, 2024

GregValiant force-pushed the DisplayInfoOnLCD branch from 2e5cd5f to 3cd4efb Compare April 3, 2024 03:08

GregValiant marked this pull request as draft April 3, 2024 13:01

GregValiant force-pushed the DisplayInfoOnLCD branch from 3cd4efb to 2061fba Compare April 3, 2024 13:20

GregValiant force-pushed the DisplayInfoOnLCD branch from 2061fba to da0fe19 Compare April 3, 2024 15:31

Delete DisplayInfoOnLCD.zip

9fe3648

Should not have been included.

GregValiant requested a review from HellAholic April 7, 2024 13:05

Merge branch 'main' into DisplayInfoOnLCD

8da792a

GregValiant marked this pull request as ready for review April 7, 2024 13:08

HellAholic reviewed Apr 8, 2024

View reviewed changes

plugins/PostProcessingPlugin/scripts/DisplayInfoOnLCD.py Outdated Show resolved Hide resolved

HellAholic reviewed Apr 8, 2024

View reviewed changes

plugins/PostProcessingPlugin/scripts/DisplayInfoOnLCD.py Outdated Show resolved Hide resolved

Update DisplayInfoOnLCD.py

e7a1bf8

Revised the M118 lines and insertion point in the gcode. Revised M117 same. Added nozzle size and filament type to data[0]

GregValiant added 6 commits January 8, 2025 07:46

Update DisplayInfoOnLCD.py

da0b99c

Added "global_stack" variable.

Update DisplayInfoOnLCD.py

984c19d

Bug fix.

Update DisplayInfoOnLCD.py

043afdb

Update. Remove vestigial line of code at line 530.

Update DisplayInfoOnLCD.py

a8849f7

Added a condition so the pause_cmd setting box is hidden unless the 'display_option' == "display_progress".

Update DisplayInfoOnLCD.py

0284771

Split functions from Execute. Added function "Add Settings" so it also works with the "filename_layer" option.

Update DisplayInfoOnLCD.py

017a05f

Changed the fialment type 'get' from: 'getProperty' to 'material.getMetaDataEntry'

HellAholic reviewed Mar 22, 2025

View reviewed changes

plugins/PostProcessingPlugin/scripts/DisplayInfoOnLCD.py Outdated Show resolved Hide resolved

Update DisplayInfoOnLCD.py

416b159

Added the "time to pause" to the user message. Update DisplayInfoOnLCD.py update

GregValiant force-pushed the DisplayInfoOnLCD branch from 3f1a04a to 416b159 Compare March 23, 2025 03:32

HellAholic reviewed Mar 23, 2025

View reviewed changes

plugins/PostProcessingPlugin/scripts/DisplayInfoOnLCD.py Outdated Show resolved Hide resolved

HellAholic reviewed Mar 23, 2025

View reviewed changes

plugins/PostProcessingPlugin/scripts/DisplayInfoOnLCD.py Outdated Show resolved Hide resolved

HellAholic reviewed Mar 23, 2025

View reviewed changes

plugins/PostProcessingPlugin/scripts/DisplayInfoOnLCD.py Show resolved Hide resolved

HellAholic reviewed Mar 23, 2025

View reviewed changes

plugins/PostProcessingPlugin/scripts/DisplayInfoOnLCD.py Outdated Show resolved Hide resolved

HellAholic reviewed Mar 23, 2025

View reviewed changes

plugins/PostProcessingPlugin/scripts/DisplayInfoOnLCD.py Outdated Show resolved Hide resolved

GregValiant added 4 commits March 23, 2025 07:09

Update DisplayInfoOnLCD.py

ee5c37b

Fixed the m118_str/m118_text confusion.

Update DisplayInfoOnLCD.py

f0d1985

Requested changes

Update DisplayInfoOnLCD.py

e1246be

Minor changes to the statistics added to the beginning of the gcode.

Update DisplayInfoOnLCD.py

1b518b8

Changes to the print statistics entered into the gcode.

GregValiant removed the PR: BooBoos 😇 Suggestions for Typos, like the NoMesh or there is a suggested refactor label Apr 14, 2025

GregValiant force-pushed the DisplayInfoOnLCD branch from ba87570 to ec4a7ad Compare April 15, 2025 21:53

Update DisplayInfoOnLCD.py

bf8d31a

Add the 'Quality Name' to the gcode with the other settings. Update DisplayInfoOnLCD.py Touchups. Update DisplayInfoOnLCD.py Minor change

GregValiant force-pushed the DisplayInfoOnLCD branch from ec4a7ad to bf8d31a Compare April 15, 2025 23:30

HellAholic approved these changes Apr 19, 2025

View reviewed changes

Update DisplayInfoOnLCD.py

6152306

Made some changes to the print stats that are added to the gcode. Update DisplayInfoOnLCD.py

GregValiant force-pushed the DisplayInfoOnLCD branch from f755749 to 6152306 Compare May 22, 2025 16:21

GregValiant and others added 2 commits June 7, 2025 09:09

Update DisplayInfoOnLCD.py

e63243b

It turns out that some firmware doesn't like colons within M118 commands.

Merge branch 'main' into DisplayInfoOnLCD

69f56cb

Update DisplayInfoOnLCD.py

3ad2c1b

Add "Electricity Cost" to the statistics added to the gcode. Update DisplayInfoOnLCD.py Formatting changes for layer heights

GregValiant force-pushed the DisplayInfoOnLCD branch from ca7312d to 3ad2c1b Compare July 2, 2025 10:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Update DisplayInfoOnLCD.py #18774

Update DisplayInfoOnLCD.py #18774

Uh oh!

GregValiant commented Mar 31, 2024 •

edited

Loading

Uh oh!

GregValiant commented Apr 3, 2024

Uh oh!

GregValiant commented Apr 7, 2024

Uh oh!

Uh oh!

Uh oh!

HellAholic commented Apr 8, 2024 •

edited

Loading

Uh oh!

GregValiant commented Apr 8, 2024

Uh oh!

github-actions bot commented Dec 30, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

HellAholic commented Mar 23, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

GregValiant commented Apr 14, 2025

Uh oh!

GregValiant commented May 22, 2025

Uh oh!

GregValiant commented Jul 1, 2025 •

edited

Loading

Uh oh!

HellAholic commented Jul 2, 2025

Uh oh!

Uh oh!

Uh oh!

Update DisplayInfoOnLCD.py #18774

Are you sure you want to change the base?

Update DisplayInfoOnLCD.py #18774

Uh oh!

Conversation

GregValiant commented Mar 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

How Has This Been Tested?

Checklist:

Uh oh!

GregValiant commented Apr 3, 2024

Uh oh!

GregValiant commented Apr 7, 2024

Uh oh!

Uh oh!

Uh oh!

HellAholic commented Apr 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GregValiant commented Apr 8, 2024

Uh oh!

github-actions bot commented Dec 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

Uh oh!

Uh oh!

HellAholic commented Mar 23, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

GregValiant commented Apr 14, 2025

Uh oh!

GregValiant commented May 22, 2025

Uh oh!

GregValiant commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HellAholic commented Jul 2, 2025

Uh oh!

Uh oh!

GregValiant commented Mar 31, 2024 •

edited

Loading

HellAholic commented Apr 8, 2024 •

edited

Loading

github-actions bot commented Dec 30, 2024 •

edited

Loading

GregValiant commented Jul 1, 2025 •

edited

Loading