Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GameData\000_USITools\Comms.cfg still misses @ #131

Open
Gordon-Dry opened this issue Oct 20, 2018 · 7 comments
Open

GameData\000_USITools\Comms.cfg still misses @ #131

Gordon-Dry opened this issue Oct 20, 2018 · 7 comments

Comments

@Gordon-Dry
Copy link

Gordon-Dry commented Oct 20, 2018

Line 1:
@PART[*]:HAS[!MODULE[ModuleDataTransmitter],MODULE[ModuleCommand]]
should be
@PART[*]:HAS[!MODULE[ModuleDataTransmitter],@MODULE[ModuleCommand]]

@7ranceaddic7
Copy link

Actually, I think they have to be split up; you can't edit (@) and bang (!) within the same HAS directive ... I think.

@part[*]:HAS[!MODULE[ModuleDataTransmitter]]:HAS[@module[ModuleCommand]]

@Gordon-Dry
Copy link
Author

I will test that

@Gordon-Dry
Copy link
Author

Looks good

@7ranceaddic7
Copy link

Just so you know, I corrected another config in the opposite direction.

Having separate :HAS directives makes MM perform and execute the processed PART TWICE. So with ...

@part[*]:HAS[MODULE[someModule]]:HAS[MODULE[anotherModule]]
{
+module=whatever
}

If PART has both someModule & anotherModule, whatever will be created at each instance of *Module.

But with ...

@part[*]:HAS[MODULE[someModule,anotherModule]]
{
+module=whatever
}

Any PART with both someModule & anotherModule will have whatever created only once.

@Gordon-Dry
Copy link
Author

ofc - dunno why I overlooked that one ...

@Gordon-Dry
Copy link
Author

My first one was right btw - I have seen it often and use it myself.

You misleaded me... ;)

So,
@PART[*]:HAS[!MODULE[ModuleDataTransmitter],@MODULE[ModuleCommand]]

@7ranceaddic7
Copy link

Yeah, looking back that would make more sense given what I said about someModule and anotherModule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants