Skip to content

Download Dialogue displays options for images above maxWidth #1706

@jamesmisson

Description

@jamesmisson

UV version:

 universalviewer@4.2.1

I'm submitting a:

  • bug report => please fork one of these codesandbox examples with a repro of your issue and include a link to it below
  • feature request => please use the user stories repo
  • support request => Please do not submit support requests here, use stackoverflow

Current behavior:

For image servers that have put a maxWidth on specific images in image API 3.0, the download dialogue displays links to these images when it shouldn't. This feature is working for image API <2.1. so I think it's (at least) something that needs updating in Manifesto.

Expected behavior:

The dead links to download images above the width restrictions should not appear in the download dialogue.

Steps to reproduce:

The relevant manifests are currently on a staging server so I won't post them here yet.

Related code:
In line 276 of the OSD download dialogue:

        const maxDimensions: Size | null = canvas.getMaxDimensions();

this is currently returning null for Image API 3.0 with maxWidth set in the info.json

Other information:

There is an existing issue on Manifesto that is probably the root of this so I'll look into it: IIIF-Commons/manifesto#132

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions