fix: disable Talos >= 1.10 for now as Omni isn't ready for it yet

Kernel args were constant in Talos before UKI support, so Omni drops
them by default when generating/rebuilding schematics.
So if the Machines are upgraded to 1.10 and switch to UKI, they will be
disconnected from Omni.

Do not allow using Talos 1.10, until we introduce proper support for
the UKI non-secureboot machines.

Signed-off-by: Artem Chernyshev <[email protected]>

Author: Unix4ever

internal/backend/runtime/omni/controllers/omni/versions.go

@@ -247,9 +247,7 @@ func (ctrl *VersionsController) reconcileTalosVersions(ctx context.Context, r co
 	talosVersions := ctrl.getVersionsAfter(allVersions, minDiscoveredTalosVersion, config.Config.EnableTalosPreReleaseVersions)
 
 	talosVersions = xslices.FilterInPlace(talosVersions, func(v string) bool {
-		_, denylisted := consts.DenylistedTalosVersions[v]
-
-		return !denylisted
+		return consts.DenylistedTalosVersions.IsAllowed(v)
 	})
 
 	err = forAllCompatibleVersions(talosVersions, k8sVersions, func(talosVer string, compatibleK8sVersions []string) error {

internal/pkg/constants/versions.go

@@ -5,6 +5,12 @@
 
 package constants
 
+import (
+	"fmt"
+
+	"github.com/blang/semver/v4"
+)
+
 // AnotherTalosVersion is used in the integration tests for Talos upgrade.
 const AnotherTalosVersion = "1.9.0"
 
@@ -26,7 +32,31 @@ const AnotherKubernetesVersion = "1.31.7"
 const MinKubernetesVersion = "1.24.0"
 
 // DenylistedTalosVersions is a list of versions which should never show up in the version picker.
-var DenylistedTalosVersions = map[string]struct{}{
-	"1.4.2": {}, // issue with the number of open files limit
-	"1.4.3": {}, // issue with the number of open files limit
+var DenylistedTalosVersions = Denylist{
+	"1.4.2":  {}, // issue with the number of open files limit
+	"1.4.3":  {}, // issue with the number of open files limit
+	"1.10.*": {}, // Omni is not ready for 1.10.x yet
+}
+
+// Denylist helper.
+type Denylist map[string]struct{}
+
+// IsAllowed checks if the version of Talos is allowed.
+func (d Denylist) IsAllowed(version string) bool {
+	if _, ok := d[version]; ok {
+		return false
+	}
+
+	ver, err := semver.ParseTolerant(version)
+	if err != nil {
+		return false
+	}
+
+	pattern := fmt.Sprintf("%d.%d.*", ver.Major, ver.Minor)
+
+	if _, ok := d[pattern]; ok {
+		return false
+	}
+
+	return true
 }