Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable logging? #106

Open
Ziao opened this issue Aug 22, 2024 · 5 comments
Open

Disable logging? #106

Ziao opened this issue Aug 22, 2024 · 5 comments

Comments

@Ziao
Copy link

Ziao commented Aug 22, 2024

Can you please add an option to set logging levels or to silence the library completely? It's liberally logging a lot of information with the only option being passing a custom Logger which satisfies your types. This is generally considered to be inappropriate behavior for libraries.

Thank you <3

@awalker4
Copy link
Collaborator

Hi @Ziao , thanks for the feedback! Yes, things are very noisy right now, so we'll be revisiting our logging soon. I'll make sure this is exposed for the user to control as well.

@Ziao
Copy link
Author

Ziao commented Aug 22, 2024

Awesome, thanks :)

@abaudhuin
Copy link

Any news on this ?

Passing

  debugLogger: {
    log: (message) => {},
    group: () => {},
    groupEnd: () => {},
  },

To the client does not remove the logs.

@tirandagan
Copy link

same issue - I tried every possible way to quiet it and can not get the info level logging to go away...

@jordan-homan
Copy link
Contributor

Hey all, sorry for the delayed response. We've pushed a change that reduces the logging as part of version 0.26.2. If you update to the latest version of the client, are you still seeing verbose logging?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants