count implicit traveltime transfers from same stop_id; fixes #88

Author: mpadge

DESCRIPTION

@@ -1,6 +1,6 @@
 Package: gtfsrouter
 Title: Routing with GTFS (General Transit Feed Specification) Data
-Version: 0.0.5.090
+Version: 0.0.5.091
 Authors@R: c(
     person("Mark", "Padgham", , "[email protected]", role = c("aut", "cre")),
     person("Marcin", "Stepniak", , "[email protected]", role = "aut",

codemeta.json

@@ -7,7 +7,7 @@
   "codeRepository": "https://github.com/ATFutures/gtfs-router",
   "issueTracker": "https://github.com/ATFutures/gtfs-router/issues",
   "license": "https://spdx.org/licenses/GPL-3.0",
-  "version": "0.0.5.090",
+  "version": "0.0.5.091",
   "programmingLanguage": {
     "@type": "ComputerLanguage",
     "name": "R",

src/traveltimes.cpp

@@ -93,6 +93,10 @@ bool iso::fill_one_iso (
         Iso &iso) {
 
     bool fill_vals = false, is_end_stn = false, same_trip = false;
+    bool is_transfer = false;
+    // is_transfer is used to increment "implicit" transfers to different
+    // services from same stop_id, which do not otherwise appear as transfers.
+
     int prev_trip = -1L; // int to allow -1L flag
     int ntransfers = INFINITE_INT;
     int latest_initial = -1L;
@@ -192,6 +196,7 @@ bool iso::fill_one_iso (
                     latest_initial = st.initial_depart;
                     prev_trip = static_cast <int> (st.trip);
                     ntransfers = st.ntransfers;
+                    is_transfer = st.is_transfer;
                 }
             }
 
@@ -246,6 +251,13 @@ bool iso::fill_one_iso (
         iso.earliest_departure [arrival_station] = departure_time;
     } else
     {
+        if (!same_trip && !is_transfer)
+        {
+            // connections flagged with 'is_transfer' have already had transfers
+            // incremented; this increments only "implicit" transfers from same
+            // stop_id to different service (trip_id)
+            ntransfers++;
+        }
         iso.connections [arrival_station].convec [s].ntransfers = ntransfers;
         iso.connections [arrival_station].convec [s].initial_depart = latest_initial;
     }