Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swift 3 #71

Open
kapellanos opened this issue Aug 10, 2016 · 17 comments
Open

swift 3 #71

kapellanos opened this issue Aug 10, 2016 · 17 comments

Comments

@kapellanos
Copy link

kapellanos commented Aug 10, 2016

any plan to migrate the pod to swift 3 syntax?

@kapellanos kapellanos changed the title swift 3? swift 3 Aug 10, 2016
@coneybeare
Copy link
Member

Can't accept PR's until out of beta

@KyleMay
Copy link

KyleMay commented Aug 21, 2016

Why not have a separate Swift 3 branch until it's out of beta like a lot of other libraries do?

@kevinlieser
Copy link

Whats the status?

@coneybeare
Copy link
Member

coneybeare commented Sep 11, 2016

I made the swift3 branch shortly after the above comment, nobody has send me a pull request to it as requested. https://github.com/UrbanApps/Armchair/tree/swift3

@bjaskj
Copy link

bjaskj commented Sep 19, 2016

Status? Need this to work on xcode 8 with carthage.

@coneybeare
Copy link
Member

coneybeare commented Sep 19, 2016

@bjaskj you can see the swift 3 branch here: https://github.com/UrbanApps/Armchair/tree/swift3 feel free to submit a pull request if it is not working for you.

@donpironet
Copy link

Can you please update the project to Swift 3 so I can update via carthage?

@coneybeare
Copy link
Member

@donpironet There is a swift3 branch you can use here

@donpironet
Copy link

donpironet commented Sep 29, 2016

Thanks. What do I need to specify to get it via carthage?

EDIT: it can be done via git "https://github.com/UrbanApps/Armchair.git" "swift3"

@codytwinton
Copy link

Any update on merging the swift3 branch into master and issuing a release? Especially for Cocoapods?

@donpironet
Copy link

+1 for cocoapods request.

@jlaws
Copy link

jlaws commented Oct 22, 2016

+1

1 similar comment
@3adel
Copy link

3adel commented Oct 29, 2016

+1

@makoni
Copy link

makoni commented Oct 31, 2016

Is there any good alternative? Swift 3.0.1 released and there's still nothing happened

@coneybeare
Copy link
Member

coneybeare commented Oct 31, 2016

I haven't had time to resolve the merge conflicts in the other PR's that update to the swift 3 branch. If somebody wants to submit a PR with the appropriate edits to the master branch, I will take a look and merge if all is good.

@andrewschreiber
Copy link

Meanwhile for swift 3 projects, put this in your Podfile:

pod 'Armchair', :git => 'https://github.com/UrbanApps/Armchair.git', :branch => 'swift3'

Works fine with Swift 3.0.1

@Jeehut
Copy link

Jeehut commented Apr 28, 2017

I just wanted to use this library but it seems it's not being maintained any more. @coneybeare clearly lost interest (it's more than half a year after the Swift 3 release and still no native Swift 3 support!) so I'm unstar-ing this and opting for Appirater instead which is written in Objective-C (which I wanted to prevent) but at least it's actively maintained and maps well to Swift.

In the future there will probably be a completely different approach to this issue anyway as Apple has introduced the new in-app review APIs. See the Human Interface Guidelines for it here. We just need to wait until iOS 10.3 is far more distributed amongst users ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests