-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
swift 3 #71
Comments
Can't accept PR's until out of beta |
Why not have a separate Swift 3 branch until it's out of beta like a lot of other libraries do? |
Whats the status? |
I made the swift3 branch shortly after the above comment, nobody has send me a pull request to it as requested. https://github.com/UrbanApps/Armchair/tree/swift3 |
Status? Need this to work on xcode 8 with carthage. |
@bjaskj you can see the swift 3 branch here: https://github.com/UrbanApps/Armchair/tree/swift3 feel free to submit a pull request if it is not working for you. |
Can you please update the project to Swift 3 so I can update via carthage? |
@donpironet There is a swift3 branch you can use here |
Thanks. What do I need to specify to get it via carthage? EDIT: it can be done via git "https://github.com/UrbanApps/Armchair.git" "swift3" |
Any update on merging the |
+1 for cocoapods request. |
+1 |
1 similar comment
+1 |
Is there any good alternative? Swift 3.0.1 released and there's still nothing happened |
I haven't had time to resolve the merge conflicts in the other PR's that update to the swift 3 branch. If somebody wants to submit a PR with the appropriate edits to the master branch, I will take a look and merge if all is good. |
Meanwhile for swift 3 projects, put this in your Podfile:
Works fine with Swift 3.0.1 |
I just wanted to use this library but it seems it's not being maintained any more. @coneybeare clearly lost interest (it's more than half a year after the Swift 3 release and still no native Swift 3 support!) so I'm unstar-ing this and opting for Appirater instead which is written in Objective-C (which I wanted to prevent) but at least it's actively maintained and maps well to Swift. In the future there will probably be a completely different approach to this issue anyway as Apple has introduced the new in-app review APIs. See the Human Interface Guidelines for it here. We just need to wait until iOS 10.3 is far more distributed amongst users ... |
any plan to migrate the pod to swift 3 syntax?
The text was updated successfully, but these errors were encountered: