Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elements queries not working properly #224

Open
dhaval1406 opened this issue Sep 3, 2015 · 4 comments
Open

Elements queries not working properly #224

dhaval1406 opened this issue Sep 3, 2015 · 4 comments

Comments

@dhaval1406
Copy link

First of all - great work guys, very impressive!

For example, I have selected Movies Genres dataset, and trying to apply a query filter on Average Rating but don't see minimum or maximum as mentioned in the paper. Also query filter is not working on any other numeric field.

* How can I select movies that were release up to1980 and after 1980?*

image

@dhaval1406
Copy link
Author

Just a quick update - I have been dicing and slicing at the code to figure this out. I have used an older version (below) and it worked like a charm. So down the road somewhere, the functionality to provide more options for numeric attribute is broke.

https://github.com/VCG/upset/blob/d37b4fa093d49af79f3b8b309be81ffd177f6bbf/filter.js

@alexsb
Copy link
Member

alexsb commented Sep 5, 2015

Thanks for reporting the issue and finding the original version that worked. We're currently very busy with other projects, but if you can submit a pull request, we'll review that and merge it into the deployed version.

@Ollipolli1909
Copy link

Another related issue, querry results only show top100 elements even if more in a set

@SingingMeerkat
Copy link

Hi guys!

As dhaval said, it is a great work, I find it very impressive and useful!
I also had this query problem and as dhaval said that the previous file was working well I tried to see which difference between the current version and the older one could make this error happen.

I am completely beginning in JavaScript so I do not fully understand what you made but it seems that it is because of an event change within line 219 from "change" to "changeDataset", for calling the 'initializeFilterList' function! I tried and went back to "change" and it worked!

Maybe changeDataset is supposed to do something more, but I couldn't tell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants