Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use internal data folder for updates. #38

Open
antoniovazquezblanco opened this issue Aug 14, 2012 · 7 comments
Open

Use internal data folder for updates. #38

antoniovazquezblanco opened this issue Aug 14, 2012 · 7 comments

Comments

@antoniovazquezblanco
Copy link
Contributor

I was asking myself if the data folder inside the app can be used for installing data updates. This should reduce the space ocupied by VDrift by avoiding duplicated files and it will avoid conflicts in future app updates as data will be the one included in the app.

Timo6 added a commit to Timo6/vdrift that referenced this issue Aug 14, 2012
Timo6 added a commit to Timo6/vdrift that referenced this issue Aug 14, 2012
Use data folder for downloaded cars/tracks if writeable, if not use current method (settings folder).
@Timo6
Copy link
Member

Timo6 commented Aug 14, 2012

@logzero What do you think about this?

@logzero
Copy link
Member

logzero commented Aug 15, 2012

On linux/windows installation directory is not writable(multi-user, security). No idea how it works with OSX. If you have to install the vdrift data per user anyway it should be fine I guess.

Maybe the installer should clean up the remains of the previous version btw. I even have been thinking about using per release directories(e.g. 2012-09 release: VDrift129/.vdrift129) on win/linux to deal with this issue, support multiple versions installations?

@Timo6
Copy link
Member

Timo6 commented Aug 15, 2012

My second commit uses the current method (setting folder) if it can't write to the data folder. /Applications (standard place to put apps) is only writeable by admins on OS X, but users can put VDrift anywhere they like (e.g. /Users/user/Applications). However, since by default data is now inside the application bundle, I don't know what the situation is. I'll test in a minute. EDIT: non-admins can't write inside /Applications/VDrift.app/
If VDrift in is the former it is available to all users, so this would prevent the same data being downloaded multiple time. If it is in the later it is only available to user.

Could this be put into VDrift itself, rather than the installer - if the application version is different to the settings folder version, make a new one. If possible it needs to copy over everything it can for the best user experience.

@antoniovazquezblanco
Copy link
Contributor Author

For MacOS users having everything in the app bundle is very clean and handy. Maybe settings would be in the Library/Preferences folder for keeping them between versions.

For linux users sudo or setuid flag would be interesting... For windows users UAC integration seems a bit difficult but may also be possible.

@Timo6
Copy link
Member

Timo6 commented Aug 15, 2012

Library/Preferences should never be accessed directly, only using cocoa to automatically create .plist files, which I don't think is feasible for us.

@antoniovazquezblanco
Copy link
Contributor Author

I mean in the correspondent settings folder.

@Timo6
Copy link
Member

Timo6 commented Aug 30, 2012

@logzero Any further thoughts on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants