Avoid use-after-free.

Reported by Dirk Meyer in bug 419. I made a very small change to the given
patch only.


git-svn-id: https://svn.code.sf.net/p/vice-emu/code/trunk@45927 379a1393-f5fb-40a0-bcee-ef074d9b53f7

Author: Rhialto

vice/src/arch/gtk3/joystickdrv/joystick_bsd.c

@@ -649,12 +649,14 @@ void joystick_arch_init(void)
             /* scan axes, buttons and hats */
             if (scan_inputs(joydev)) {
                 /* OK: try to register */
+                char *backup_name = lib_strdup(joydev->name);
+
                 if (!joystick_device_register(joydev)) {
                     /* failure */
+                    /* joydev is already destroyed */
                     log_warning(bsd_joy_log,
                                 "failed to register device %s (\"%s\")",
-                                joydev->node, joydev->name);
-                    joystick_device_free(joydev);
+                                node, backup_name);
                 } else {
                     priv = joydev->priv;
                     /* allocate arrays for previous input states */
@@ -665,6 +667,7 @@ void joystick_arch_init(void)
                     priv->prev_hats    = lib_calloc((size_t)joydev->num_hats,
                                                     sizeof *priv->prev_hats);
                 }
+                lib_free(backup_name);
             } else {
                 /* failure while scanning: log and free invalid device */
                 log_warning(bsd_joy_log,