Skip to content

Commit f53ae73

Browse files
authored
Fix job status handling and enhance error logging (#59)
1 parent 3979211 commit f53ae73

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

src/services/simulation_service/core/infrastructure/server/src/_simulation_server_grpc.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -202,6 +202,7 @@ async def SubmitSimulationJob(self, request, context):
202202
sm.JobStatus.SUCCESS,
203203
sm.JobStatus.FAILED,
204204
sm.JobStatus.TIMEOUT,
205+
sm.JobStatus.ERROR,
205206
]:
206207
context.set_code(grpc.StatusCode.INVALID_ARGUMENT)
207208
context.set_details(

src/services/simulation_service/core/infrastructure/worker/src/_simulation_worker_grpc.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,11 +75,13 @@ async def handle_simulation_job(stub, simulation_job, worker_id):
7575
status = sm.JobStatus.TIMEOUT
7676
logger.warning(f"Worker {worker_id}: Simulation {job_id} timed out")
7777
elif simulation_status == SimulationStatus.FAILED:
78-
status = sm.JobStatus.ERROR
78+
status = sm.JobStatus.FAILED
7979
logger.error(f"Worker {worker_id}: Simulation {job_id} failed")
8080
else:
8181
status = sm.JobStatus.ERROR
82-
logger.error(f"Worker {worker_id}: Simulation {job_id} failed")
82+
logger.error(
83+
f"Worker {worker_id}: Simulation {job_id} encountered an unknown status: {simulation_status}"
84+
)
8385

8486
response = await submit_simulation_job(
8587
stub, simulation_job, simulation_result, status

0 commit comments

Comments
 (0)