Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS用XCFrameworkの"onnxruntime.dylib"が"onnxruntime"になっている #54

Closed
1 of 3 tasks
qryxip opened this issue Sep 3, 2024 · 4 comments
Closed
1 of 3 tasks
Labels

Comments

@qryxip
Copy link
Member

qryxip commented Sep 3, 2024

不具合の内容

iOS用XCFrameworkの中身はこうなっており、"onnxruntime.dylib"ではなく"onnxruntime"が入っています。重大度で言うと、 VOICEVOX/voicevox_project#24 の支障となります(公式のONNX Runtimeのビルドが使えなくなるので)。

zipinfo -1 ~/Downloads/onnxruntime-ios-xcframework-1.17.3.zip
onnxruntime.xcframework/
onnxruntime.xcframework/Info.plist
onnxruntime.xcframework/ios-arm64/
onnxruntime.xcframework/ios-arm64/onnxruntime.framework/
onnxruntime.xcframework/ios-arm64/onnxruntime.framework/Info.plist
onnxruntime.xcframework/ios-arm64/onnxruntime.framework/Modules/
onnxruntime.xcframework/ios-arm64/onnxruntime.framework/Modules/module.modulemap
onnxruntime.xcframework/ios-arm64/onnxruntime.framework/onnxruntime
onnxruntime.xcframework/ios-arm64_x86_64-simulator/
onnxruntime.xcframework/ios-arm64_x86_64-simulator/onnxruntime.framework/
onnxruntime.xcframework/ios-arm64_x86_64-simulator/onnxruntime.framework/Info.plist
onnxruntime.xcframework/ios-arm64_x86_64-simulator/onnxruntime.framework/Modules/
onnxruntime.xcframework/ios-arm64_x86_64-simulator/onnxruntime.framework/Modules/module.modulemap
onnxruntime.xcframework/ios-arm64_x86_64-simulator/onnxruntime.framework/onnxruntime

COREの方ではちゃんとvoicevox_core.dylibになっているのですが、COREとonnxruntime-builderでXCFrameworkの作り方が異なっていそうなので修正すべき箇所がぱっとはわかりませんでした。これを機に #49 をやってしまってもいいかもしれません。

現象・ログ

再現手順

期待動作

VOICEVOXのバージョン

N/A

OSの種類/ディストリ/バージョン

  • Windows
  • macOS
  • Linux

その他

@qryxip qryxip added the バグ label Sep 3, 2024
@qryxip
Copy link
Member Author

qryxip commented Sep 3, 2024

あ、もしかして逆かも…
https://zenn.dev/char/scraps/930fd4abccf470

@qryxip
Copy link
Member Author

qryxip commented Sep 3, 2024

逆ですね。CORE側の.dylibが無くなるべき。 #49 を試してもこうなってました。

2024-09-03T17:13:35.3171320Z     │   ├── onnxruntime.framework
2024-09-03T17:13:35.3172830Z     │   │   ├── Headers
2024-09-03T17:13:35.3174190Z     │   │   │   ├── cpu_provider_factory.h
2024-09-03T17:13:35.3177070Z     │   │   │   ├── onnxruntime_c_api.h
2024-09-03T17:13:35.3178660Z     │   │   │   ├── onnxruntime_cxx_api.h
2024-09-03T17:13:35.3180090Z     │   │   │   ├── onnxruntime_cxx_inline.h
2024-09-03T17:13:35.3181780Z     │   │   │   ├── onnxruntime_float16.h
2024-09-03T17:13:35.3183360Z     │   │   │   ├── onnxruntime_run_options_config_keys.h
2024-09-03T17:13:35.3185790Z     │   │   │   └── onnxruntime_session_options_config_keys.h
2024-09-03T17:13:35.3187600Z     │   │   ├── Info.plist
2024-09-03T17:13:35.3188730Z     │   │   └── onnxruntime

@qryxip qryxip closed this as not planned Won't fix, can't repro, duplicate, stale Sep 3, 2024
@qryxip
Copy link
Member Author

qryxip commented Sep 4, 2024

COREの方ではちゃんとvoicevox_core.dylibになっているのですが、

逆ですね。CORE側の.dylibが無くなるべき。

0.15.0-preview.16を見てたのですが、これ VOICEVOX/voicevox_core#723 の前ですね。確認はしていませんが、今はBashスクリプトの内容的にCORE側もvoicevox_coreになっているはず、なので対応は不要なはず?

@qryxip
Copy link
Member Author

qryxip commented Sep 4, 2024

qryxip/voicevox_coreで最近999.999.999のリリースを試してたことを思い出しました。ちゃんとvoicevox_coreになってそう。

zipinfo -1 ~/Downloads/voicevox_core-ios-xcframework-cpu-999.999.999.zip
voicevox_core.xcframework/
voicevox_core.xcframework/Info.plist
voicevox_core.xcframework/ios-arm64/
voicevox_core.xcframework/ios-arm64/voicevox_core.framework/
voicevox_core.xcframework/ios-arm64/voicevox_core.framework/Headers/
voicevox_core.xcframework/ios-arm64/voicevox_core.framework/Headers/voicevox_core.h
voicevox_core.xcframework/ios-arm64/voicevox_core.framework/Info.plist
voicevox_core.xcframework/ios-arm64/voicevox_core.framework/Modules/
voicevox_core.xcframework/ios-arm64/voicevox_core.framework/Modules/module.modulemap
voicevox_core.xcframework/ios-arm64/voicevox_core.framework/voicevox_core
voicevox_core.xcframework/ios-arm64_x86_64-simulator/
voicevox_core.xcframework/ios-arm64_x86_64-simulator/voicevox_core.framework/
voicevox_core.xcframework/ios-arm64_x86_64-simulator/voicevox_core.framework/Headers/
voicevox_core.xcframework/ios-arm64_x86_64-simulator/voicevox_core.framework/Headers/voicevox_core.h
voicevox_core.xcframework/ios-arm64_x86_64-simulator/voicevox_core.framework/Info.plist
voicevox_core.xcframework/ios-arm64_x86_64-simulator/voicevox_core.framework/Modules/
voicevox_core.xcframework/ios-arm64_x86_64-simulator/voicevox_core.framework/Modules/module.modulemap
voicevox_core.xcframework/ios-arm64_x86_64-simulator/voicevox_core.framework/voicevox_core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant