Skip to content

Tags Performance with Command Palette #7054

Open
@bpotchik

Description

@bpotchik

Command palette is slow to open on binaries with a large number of tags.

Repro:

  • Open the calm-bird-jumps-softly binary.
  • Let it analyze for a bit.
  • Try command palette. (Taking 1 second+ before it displays)

std::__1::vector<BinaryNinjaCore::RefBinaryNinjaCore::Tag, BinaryNinjaCore::Allocator<BinaryNinjaCore::RefBinaryNinjaCore::Tag, std::__1::vector<BinaryNinjaCore::RefBinaryNinjaCore::Tag, std::__1::allocator<BinaryNinjaCore::RefBinaryNinjaCore::Tag>>>>::beginabi:ne190102
BinaryNinjaCore::Function::GetTagReferencesOfType(BinaryNinjaCore::RefBinaryNinjaCore::TagType)
BinaryNinjaCore::BinaryView::GetAllTagReferencesOfType(BinaryNinjaCore::RefBinaryNinjaCore::TagType) const
BNGetAllTagReferencesOfType
BinaryNinja::BinaryView::GetAllTagReferencesOfType(BinaryNinja::RefBinaryNinja::TagType)
View::View()::$_64::operator()(UIActionContext const&, int) const

Metadata

Metadata

Assignees

No one assigned

    Labels

    Effort: TrivialIssue should take < 1 dayImpact: MediumIssue is impactful with a bad, or no, workaroundUI: Command PaletteIssues with the Command PaletteUI: TagsIssues with the Tags widget

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions