-
Notifications
You must be signed in to change notification settings - Fork 275
Labels
Component: CoreIssue needs changes to the coreIssue needs changes to the coreCore: WorkflowIssue involves the workflow systemIssue involves the workflow systemEffort: TrivialIssues require < 1 day of workIssues require < 1 day of workImpact: LowIssue is a papercut or has a good, supported workaroundIssue is a papercut or has a good, supported workaround
Milestone
Description
Version and Platform (required):
- Binary Ninja Version: 5.1.7870-dev
- OS: macOS 15.5
- CPU Architecture: arm64
Bug Description:
Workflow::Clone passes the result of BNWorkflowClone into Workflow::Workflow which then calls BNNewWorkflowReference. Since BNWorkflowClone returns a +1 object, this results in an extra ref on the object that is leaked.
It looks like other C++ API types take ownership of the BNFoo* object that is passed to them rather than adding an additional reference. I haven't looked at clients of Workflow to determine whether that change is safe to make.
Steps To Reproduce:
I found this by doing:
MallocStackLoggingNoCompact=YES /path/to/binaryninja.app/Contents/MacOS/binaryninjaleaks binaryninja
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Component: CoreIssue needs changes to the coreIssue needs changes to the coreCore: WorkflowIssue involves the workflow systemIssue involves the workflow systemEffort: TrivialIssues require < 1 day of workIssues require < 1 day of workImpact: LowIssue is a papercut or has a good, supported workaroundIssue is a papercut or has a good, supported workaround