Skip to content
This repository has been archived by the owner on Oct 5, 2018. It is now read-only.

add labels to align with origin-aggregated-logging #15

Open
t0ffel opened this issue Jul 6, 2018 · 8 comments
Open

add labels to align with origin-aggregated-logging #15

t0ffel opened this issue Jul 6, 2018 · 8 comments

Comments

@t0ffel
Copy link
Contributor

t0ffel commented Jul 6, 2018

Current deployment of origin-aggregated-logging assigns the following labels:
logging-infra=elasticsearch
component=es or component=es-ops

@t0ffel
Copy link
Contributor Author

t0ffel commented Jul 6, 2018

@ewolinetz I'm thinking about making labels propagate.
i.e. if a label appears on a custom resource, operator will add label to all the downstream components. What do you think?

this is needed for backward compatibility and integration tests

@ewolinetz
Copy link

@t0ffel do you mean within the CRD spec, or on the CRD itself?
I think that could be beneficial if we could give a label to the CRD and then the deployments that are created from that CRD would also be set to have the same labels.

@t0ffel
Copy link
Contributor Author

t0ffel commented Jul 6, 2018

@ewolinetz I mean custom resource for a specific elasticsearch cluster.
If a label is added to this custom resource, same label will be added to the deployments, services, services, configmaps constructed for this cluster.

that would mean the labels logging-infra=elasticsearch and component=es/component=es-ops need to be added to the cluster's CRD in openshift/openshift-ansible#8701

@t0ffel
Copy link
Contributor Author

t0ffel commented Jul 7, 2018

done in #18

@t0ffel t0ffel closed this as completed Jul 7, 2018
@ewolinetz
Copy link

@t0ffel we don't currently label our configmap, services, nor secrets with those labels though... currently those are unique only to our DCs.

I think it could be beneficial to add those, however would it be required that the operator is managing those objects if those labels are present? (regarding adopting current deployments)

@t0ffel
Copy link
Contributor Author

t0ffel commented Jul 11, 2018

@ewolinetz at the moment if there are no configmaps, services available the operator will create them and in this case these resources will get appropriate labels.
If configmaps/services already exist then operator won't add labels to them - I can change these if needed..

secrets are not getting re-created.

@ewolinetz
Copy link

I think as part of adopting the existing cluster, we would want to labels those api objects...

@t0ffel
Copy link
Contributor Author

t0ffel commented Jul 12, 2018

ok

@t0ffel t0ffel reopened this Jul 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants