Merge pull request Zilliqa#41 from noelyoo/declare-const-if-never-reassigned

Use const if never reassigned

Author: AmritKumar

lib/schnorr.js

@@ -36,8 +36,8 @@ const schnorr = exports;
  */
 
 schnorr.hash = function hash(q, pubkey, msg) {
-  let totalLength = 66 + msg.byteLength // 33 q + 33 pubkey + variable msgLen
-  let Q = q.toArrayLike(Buffer, 'be', 33);
+  const totalLength = 66 + msg.byteLength // 33 q + 33 pubkey + variable msgLen
+  const Q = q.toArrayLike(Buffer, 'be', 33);
   const B = Buffer.allocUnsafe(totalLength);
 
   Q.copy(B, 0);
@@ -70,8 +70,8 @@ schnorr.trySign = function trySign(msg, prv, k, pn, pubKey) {
   if (k.gte(curve.n))
     return null;
 
-  let Q = curve.g.mul(k);
-  let compressedQ = new BN(Q.encodeCompressed());
+  const Q = curve.g.mul(k);
+  const compressedQ = new BN(Q.encodeCompressed());
 
   const r = schnorr.hash(compressedQ, pubKey, msg);
   const h = r.clone();
@@ -139,8 +139,8 @@ schnorr.verify = function verify(msg, signature, key) {
   const l = kpub.mul(sig.r);
   const r = curve.g.mul(sig.s);
 
-  let Q = l.add(r);
-  let compressedQ = new BN(Q.encodeCompressed());
+  const Q = l.add(r);
+  const compressedQ = new BN(Q.encodeCompressed());
 
   const r1 = schnorr.hash(compressedQ, key, msg);