Skip to content

Commit d0222b2

Browse files
committed
feat: add transformRatioLocale config for transformRatio text in funnel tooltip, #3704
1 parent 3a09d67 commit d0222b2

File tree

6 files changed

+35
-5
lines changed

6 files changed

+35
-5
lines changed
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
{
2+
"changes": [
3+
{
4+
"packageName": "@visactor/vchart",
5+
"comment": "feat: add `transformRatioLocale` config for transformRatio text in funnel tooltip, #3704",
6+
"type": "none"
7+
}
8+
],
9+
"packageName": "@visactor/vchart"
10+
}

docs/assets/option/en/series/funnel.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -166,3 +166,7 @@ Min length of guide line. Default is 20px. Supported since version `1.12.7`
166166
###${prefix} state(Object)
167167

168168
{{ use: mark-state-style() }}
169+
170+
#${prefix} transformRatioLocale(String)
171+
172+
Supported since version `1.13.6`, the built-in tooltip text for the funnel chart conversion layer is set to "Conversion Rate" by default in Chinese.

docs/assets/option/zh/series/funnel.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -167,3 +167,7 @@
167167
###${prefix} state(Object)
168168

169169
{{ use: mark-state-style() }}
170+
171+
#${prefix} transformRatioLocale(String)
172+
173+
`1.13.6`版本支持,漏斗图转化层的 tooltip 内置文案,默认为“转化率”中文。

packages/vchart/src/chart/funnel/funnel-transformer.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@ export class FunnelChartSpecTransformer<T extends IFunnelChartSpec> extends Base
2525
'minSize',
2626
'gap',
2727
'isCone',
28-
'range'
28+
'range',
29+
'transformRatioLocale'
2930
]);
3031

3132
return series;

packages/vchart/src/series/funnel/interface.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,12 @@ export interface IFunnelSeriesSpec extends ISeriesSpec, IAnimationSpec<FunnelMar
8484
* @since 1.10.1
8585
*/
8686
heightRatio?: number;
87+
/**
88+
* 漏斗图转化率文案,用于转化层 tooltip key 的显示内容
89+
* @since 1.13.5
90+
* @default '转化率'
91+
* */
92+
transformRatioLocale?: string;
8793
/**
8894
* 漏斗层样式
8995
*/

packages/vchart/src/series/funnel/tooltip-helper.ts

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,17 @@ import type { TooltipHandlerParams } from '../../component/tooltip/interface';
77
import type { Datum } from '@visactor/vgrammar-core';
88

99
export class FunnelSeriesTooltipHelper extends BaseSeriesTooltipHelper implements ISeriesTooltipHelper {
10+
private _transformRatioLocale;
11+
12+
constructor(series: IFunnelSeries) {
13+
super(series);
14+
this._transformRatioLocale = series.getSpec()?.transformRatioLocale ?? `转化率`;
15+
}
16+
1017
dimensionTooltipTitleCallback = (datum: Datum, params?: TooltipHandlerParams) => {
1118
const series = this.series as IFunnelSeries;
1219
if (params?.mark?.name === SeriesMarkNameEnum.transform) {
13-
// TODO: i18n
14-
return `转化率`;
20+
return this._transformRatioLocale;
1521
}
1622
return this._getDimensionData(datum) ?? datum.properties?.[`${series.getCategoryField()}`];
1723
};
@@ -26,8 +32,7 @@ export class FunnelSeriesTooltipHelper extends BaseSeriesTooltipHelper implement
2632

2733
markTooltipKeyCallback = (datum: Datum, params?: TooltipHandlerParams) => {
2834
if (params?.mark?.name === SeriesMarkNameEnum.transform) {
29-
// TODO: i18n
30-
return `转化率`;
35+
return this._transformRatioLocale;
3136
}
3237
const { dimensionFields, seriesFields } = this._seriesCacheInfo;
3338
const subDimensionField = dimensionFields[dimensionFields.length - 1];

0 commit comments

Comments
 (0)