Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace broken links leading to "Help/About" and old Wiki pages #1714

Closed
andreoda opened this issue Mar 15, 2024 · 6 comments · Fixed by #1822
Closed

Replace broken links leading to "Help/About" and old Wiki pages #1714

andreoda opened this issue Mar 15, 2024 · 6 comments · Fixed by #1822
Labels
bug/error Bugs and errors (timeout) complexity: unknown Unknown days of work content: albums Album entries content: artists Artist entries content: songs Song entries content: Wiki VocaDB Wiki feedback-wanted Feedback and further discussion needed (open questions) guidance User instructions/guidelines priority: high Issues/Tasks that should be done ASAP weblink Domain object: URL, weblink, hyperlink

Comments

@andreoda
Copy link
Member

andreoda commented Mar 15, 2024

The "Help/About" page got removed from the sidebar but we forgot to replace the links forwarding to it.
One example is the "guide" link when being on draft entries:
Screenshot_20240313-085514
Screenshot by szhublox
Leading to an error page: https://vocadb.net/Help/guidelines#glsongs

We need to find all and forward them to the specific VocaDB Wiki articles instead.

@andreoda andreoda added bug/error Bugs and errors (timeout) priority: low Issues/Tasks that are not so important content: songs Song entries guidance User instructions/guidelines content: albums Album entries content: artists Artist entries weblink Domain object: URL, weblink, hyperlink complexity: unknown Unknown days of work labels Mar 15, 2024
@szhublox
Copy link
Collaborator

szhublox commented Apr 6, 2024

Additionally, the tooltip on the song edit page

Primary name (in one or more languages)

references "the guide" rather than the wiki. It's not a link though. And:

  • one reference to /Help/guidelines#${section}
  • song edit page validation for cover with no original
  • translations referencing Help/Guidelines
  • internal references to "Help" endpoint
    • especially VocaDbWeb/Views/Shared/Partials/Knockout/_EntryValidationMessage.cshtml and VocaDbWeb/Views/Shared/Partials/Shared/_DraftMessage.cshtml

@andreoda
Copy link
Member Author

Note: The old Wiki got replaced with the new Wiki, so we need to replace links leading to that as well.

@andreoda andreoda added the content: Wiki VocaDB Wiki label Apr 11, 2024
@andreoda andreoda changed the title Replace broken links leading to "Help/About" page Replace broken links leading to "Help/About" and old Wiki pages Apr 11, 2024
@andreoda andreoda pinned this issue Apr 11, 2024
@andreoda andreoda added priority: high Issues/Tasks that should be done ASAP and removed priority: low Issues/Tasks that are not so important labels Apr 11, 2024
@FinnRG
Copy link
Member

FinnRG commented Apr 11, 2024

Note: The old Wiki got replaced with the new Wiki, so we need to replace links leading to that as well.

We have redirects for the old wiki urls. Do you know of links that don't redirect properly (There were some reorganizations which could have broken some of them)?

@andreoda
Copy link
Member Author

andreoda commented Apr 11, 2024

@FinnRG
For example: I replaced a link on this page: https://vocadb.net/discussion/topics/637 leading to the old wiki which resulted in an error page.
-> https://wiki.vocadb.net/docs/documentation/vocadb-changelog
I already replaced it so I can not send the old link here.
I am assuming that other discussion posts and comments or entries contain broken links.

@mn7216
Copy link
Contributor

mn7216 commented Apr 15, 2024

As a quick note: Both the "guidelines" link and "Frequently asked questions" links are broken on this wiki page

@andreoda andreoda added the feedback-wanted Feedback and further discussion needed (open questions) label May 18, 2024
@saturclay
Copy link
Contributor

These links are broken on TouhouDB and UtaiteDB as well; would it be possible when fixing them to have them link to different pages for each site?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/error Bugs and errors (timeout) complexity: unknown Unknown days of work content: albums Album entries content: artists Artist entries content: songs Song entries content: Wiki VocaDB Wiki feedback-wanted Feedback and further discussion needed (open questions) guidance User instructions/guidelines priority: high Issues/Tasks that should be done ASAP weblink Domain object: URL, weblink, hyperlink
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants