test: remove duplicate assertion with thread safety test

Author: weklund

test/unit/base/test_subscription_controller_u.py

@@ -116,30 +116,6 @@ def test_has_subscription(subscription_controller, subscriptions_config, channel
     assert result is expected
 
 
-@pytest.mark.parametrize("retries,timeout,expected_retries,expected_timeout", [
-    (None, None, DEFAULT_SUBSCRIPTION_RETRIES, DEFAULT_SUBSCRIPTION_TIMEOUT),  # defaults
-    (10, 5.0, 10, 5.0),  # custom values
-    (0, 1.0, 0, 1.0),   # zero retries
-])
-def test_init_parameters(mock_processor, retries, timeout, expected_retries, expected_timeout):
-    # Arrange
-    kwargs = {}
-    if retries is not None:
-        kwargs['subscription_retries'] = retries
-    if timeout is not None:
-        kwargs['subscription_timeout'] = timeout
-
-    # Act
-    controller = SubscriptionController(subscription_processor=mock_processor, **kwargs)
-
-    # Assert
-    assert controller._subscription_processor == mock_processor
-    assert controller._subscription_retries == expected_retries
-    assert controller._subscription_timeout == expected_timeout
-    assert controller._subscriptions == {}
-    assert controller._operational_lock is not None
-
-
 @pytest.mark.parametrize("modifications,expected_status,expected_data,expected_confirmation,expected_processor_is_new", [
     # Status only
     ({'status': True}, True, {'original': 'data'}, True, False),
@@ -434,79 +410,3 @@ def controller_with_mixed_subscriptions():
     return controller
 
 
-def test_recreate_subscriptions_thread_safety_with_lock(controller_with_mixed_subscriptions, monkeypatch):
-    # Arrange
-    lock_acquired = []
-    original_acquire = controller_with_mixed_subscriptions._operational_lock.acquire
-    original_release = controller_with_mixed_subscriptions._operational_lock.release
-
-    def track_acquire(*args, **kwargs):
-        lock_acquired.append('acquire')
-        return original_acquire(*args, **kwargs)
-
-    def track_release(*args, **kwargs):
-        lock_acquired.append('release')
-        return original_release(*args, **kwargs)
-
-    monkeypatch.setattr(controller_with_mixed_subscriptions._operational_lock, 'acquire', track_acquire)
-    monkeypatch.setattr(controller_with_mixed_subscriptions._operational_lock, 'release', track_release)
-
-    # Mock subscribe method
-    mock_subscribe = MagicMock(return_value=True)
-    monkeypatch.setattr(controller_with_mixed_subscriptions, 'subscribe', mock_subscribe)
-
-    # Act
-    controller_with_mixed_subscriptions.recreate_subscriptions()
-
-    # Assert
-    # Lock should have been acquired and released
-    assert 'acquire' in lock_acquired
-    assert 'release' in lock_acquired
-    # Should be balanced (acquire followed by release)
-    assert lock_acquired.count('acquire') == lock_acquired.count('release')
-
-
-def test_recreate_subscriptions_logging_behavior(subscription_controller, monkeypatch, caplog):
-    # Arrange
-    import logging
-    caplog.set_level(logging.INFO)
-
-    subscription_controller._subscriptions = {
-        'inactive_channel_1': {
-            'status': False,
-            'data': {'key': 'value1'},
-            'needs_confirmation': True,
-            'subscription_processor': MagicMock()
-        },
-        'inactive_channel_2': {
-            'status': False,
-            'data': {'key': 'value2'},
-            'needs_confirmation': False,
-            'subscription_processor': None
-        }
-    }
-
-    # Mock subscribe to succeed for one, fail for another
-    def mock_subscribe_side_effect(channel, *args, **kwargs):
-        return channel == 'inactive_channel_1'
-
-    mock_subscribe = MagicMock(side_effect=mock_subscribe_side_effect)
-    monkeypatch.setattr(subscription_controller, 'subscribe', mock_subscribe)
-
-    # Act
-    subscription_controller.recreate_subscriptions()
-
-    # Assert
-    # Should log info about recreation attempt
-    info_logs = [record for record in caplog.records if record.levelname == 'INFO']
-    assert len(info_logs) > 0
-    info_message = info_logs[0].message
-    assert 'Recreating' in info_message
-    assert '2/2 subscriptions' in info_message
-
-    # Should log error about failed subscriptions
-    error_logs = [record for record in caplog.records if record.levelname == 'ERROR']
-    assert len(error_logs) > 0
-    error_message = error_logs[0].message
-    assert 'Failed to re-subscribe' in error_message
-    assert '1 channels' in error_message