Remember to turn dark noise off for IWCD OD PMTs (#35)

* Remember to turn dark noise off for IWCD OD PMTs

* Add check for GeomVol1002 after suggestion from @nickwp in WCSim/WCSim#408 (previously erroneously added to deprecated Tests.sh

* Remove deprecated script

* RunTests.sh is the way to live

---------

Co-authored-by: WCSim CI <[email protected]>

Author: tdealtry

Generate/macReference/wcsim_iwcdod_SensitiveDetector_Only_NoTrigger_gun500MeVem_xdir_dark0_n800_seed20230628.mac

@@ -23,6 +23,7 @@
 /control/execute /opt/Validation/Generate/macReference/daq/daq.mac
 
 /control/execute /opt/Validation/Generate/macReference/dark/darktank0.mac
+/control/execute /opt/Validation/Generate/macReference/dark/darkod0.mac
 
 /control/execute /opt/Validation/Generate/macReference/physics/gun500MeVem_xdir.mac
 

Generate/macReference/wcsim_iwcdod_SensitiveDetector_Only_NoTrigger_gun500MeVmum_xdir_dark0_n1000_seed20230628.mac

@@ -23,6 +23,7 @@
 /control/execute /opt/Validation/Generate/macReference/daq/daq.mac
 
 /control/execute /opt/Validation/Generate/macReference/dark/darktank0.mac
+/control/execute /opt/Validation/Generate/macReference/dark/darkod0.mac
 
 /control/execute /opt/Validation/Generate/macReference/physics/gun500MeVmum_xdir.mac
 

Generate/macReference/wcsim_iwcdod_SensitiveDetector_Only_NoTrigger_gun5MeVem_xdir_dark0_n5000_seed20230628.mac

@@ -23,6 +23,7 @@
 /control/execute /opt/Validation/Generate/macReference/daq/daq.mac
 
 /control/execute /opt/Validation/Generate/macReference/dark/darktank0.mac
+/control/execute /opt/Validation/Generate/macReference/dark/darkod0.mac
 
 /control/execute /opt/Validation/Generate/macReference/physics/gun5MeVem_xdir.mac
 

README.md

@@ -85,7 +85,7 @@ Then
 ## More details
 * Tests are defined in `test.txt`
   * These link to WCSim config files in `Generate/macReference/`
-  * Note that `MakeReference.py` labels tests in the range `[0,N-1]`, whilst `Tests.sh` label tests in the range `[1,N]`. Sorry
+  * Note that `MakeReference.py` labels tests in the range `[0,N-1]`, whilst `RunTests.sh` label tests in the range `[1,N]`. Sorry
 * `MakeReference.py` is used to create reference files
   * The output of this is a set of reference files in `Compare/Reference/`
     * Raw vector/number ROOT files, with information extracted from the standard *classed* WCSim ROOT files
@@ -101,7 +101,7 @@ Then
     * Adds an entry to `folderlist` (list of folders = commit hashes) and trims it to 35 entries. Then `git rm`s 
  any folders not in the `folderlist`. This ensures that the webpage does not grow expoentially
     * Pushes to
-  * `Tests.sh` does the actual tests (one test is done based on the command line option)
+  * `RunTests.sh` does the actual tests (one test is done based on the command line option)
     * Calls `Generate/Generate.sh` for the specified job, to get the same information as we have in `Compare/Reference/`
       * Runs WCSim, saving the log file (temporarily)
       * Converts the WCSim file to the raw vector/number ROOT file with `Reference/daq_readfilemain`

RunTests.sh

@@ -195,7 +195,7 @@ while read line; do
 	    if [ -f $impossiblefilename ]; then
 		rm -f $impossiblefilename
 	    fi
-	    for greps in "IMPOSSIBLE GEOMETRY"; do
+	    for greps in "IMPOSSIBLE GEOMETRY" "*** G4Exception : GeomVol1002"; do
 		grep "$greps" wcsim_run.out >> $impossiblefilename
 	    done
 	    if [ -s $impossiblefilename ]; then