In theory, this should pass lint check and tests, and upload renders as artifacts

Author: jmwright

.github/workflows/test.yaml

@@ -37,3 +37,9 @@ jobs:
         uses: coactions/setup-xvfb@v1
         with:
           run: pytest
+
+      - name: Upload rendered images as artifacts for inspection
+        uses: actions/upload-artifact@v3
+        with:
+          name: rendered-images
+          path: renders/*.png

generate.md

@@ -50,7 +50,7 @@ Currently the configuration is just a list of the networking components which ar
 
 To generate run the following:
 
-    cadorchestrator generate '["NUC10i5FNH", "Raspberry_Pi_4B", "Raspberry_Pi_4B"]'
+    cadorchestrator generate '{"device-ids": ["NUC10i5FNH", "Raspberry_Pi_4B", "Raspberry_Pi_4B"]}'
 
 This should create the `build` directory. Inside this the `printed_components` directory should contain a number of `stl` files that can be 3D printed. It will also contain `step` files for each of these components.
 

mechanical/assembly_renderer.py

@@ -101,13 +101,6 @@ def direction_axis(self):
         """
         return self._direction_axis
 
-    @name.setter
-    def direction_axis(self, axis):
-        """
-        Setter for the direction axis of the fastener.
-        """
-        self._direction_axis = axis
-
     @property
     def rotation(self):
         """

nimble_build_system/cad/fasteners.py

@@ -1,11 +1,19 @@
+"""
+Helper module to render a CadQuery model to a PNG image file.
+"""
+
 #pylint: disable=too-few-public-methods
 #pylint: disable=unused-import
 
 import cadquery as cq
 import cadquery_png_plugin.plugin  # This activates the PNG plugin for CadQuery
 from cq_annotate.callouts import add_assembly_lines
 
-def generate_render(model=None, image_format="png", file_path=None, render_options=None):
+def generate_render(model=None,
+                    image_format="png",
+                    file_path=None,
+                    render_options=None,
+                    selective_list=None):
     """
     Generates a render of an assembly.
 
@@ -24,7 +32,7 @@ def generate_render(model=None, image_format="png", file_path=None, render_optio
     if isinstance(model, cq.Assembly):
         # Handle assembly annotation
         if render_options["annotate"]:
-            add_assembly_lines(model)
+            add_assembly_lines(model, selective_list=selective_list)
 
         # Handle the varioius image formats separately
         if image_format == "png":

nimble_build_system/cad/renderer.py

@@ -1039,7 +1039,10 @@ def generate_shelf_model(self) -> cadscript.Body:
             screw_y = 7  # distance from bottom plane
             self.width_category = "standard"
             builder = ShelfBuilder(
-                self.height_in_u, width=self.width_category, depth="standard", front_type="w-pattern"
+                self.height_in_u,
+                width=self.width_category,
+                depth="standard",
+                front_type="w-pattern"
             )
             builder.make_tray(sides="slots", back="open")
             mount_sketch = cadscript.make_sketch()

nimble_build_system/cad/shelf.py

@@ -84,7 +84,8 @@ def __init__(self, device_id, rack_params, dummy=False, dummy_data:dict|None=Non
             if self.height:
                 self.height_in_u = ceil((self.height+4)/rack_params.mounting_hole_spacing)
             else:
-                raise RuntimeError("Not enough information provided to generate shelf height") from exc
+                raise RuntimeError("Not enough information provided to generate shelf height")\
+                    from exc
 
         self.shelf_id = device_dict['ShelfId']
         self.shelf_type = device_dict['Shelf']

nimble_build_system/orchestration/device.py

@@ -28,9 +28,10 @@ def test_png_rendering():
 
     # Check all of the shelf assemblies
     for cur_shelf in config._shelves:
-
-        # Set up a temporary path to export the image to that we can upload artifacts from
-        temp_dir = "./renders"
+        # Create the temporary directory if it does not exist
+        temp_dir = os.path.join(Path(os.curdir).resolve().parent, "renders")
+        if not os.path.exists(temp_dir):
+            os.makedirs(temp_dir)
 
         # Do a sample render of the shelf assembly
         cur_shelf.generate_renders(temp_dir)
@@ -51,5 +52,13 @@ def test_final_assembly_png_rendering():
     os.chdir(folder)
     assembly = AssemblyRenderer(def_file.name)
 
+    # Create the temporary directory if it does not exist
+    temp_dir = os.path.join(Path(os.curdir).resolve().parent, "renders")
+    if not os.path.exists(temp_dir):
+        os.makedirs(temp_dir)
+
     # Generate the assembly process renders
     assembly.generate_assembly_process_renders()
+
+    assert os.path.isfile(os.path.join(temp_dir, "final_assembly_step_1_annotated.png"))
+    assert os.path.isfile(os.path.join(temp_dir, "final_assembly_step_1_assembled.png"))