Skip to content

Plague Rebuild Redux #1683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 136 commits into
base: dev
Choose a base branch
from
Draft

Plague Rebuild Redux #1683

wants to merge 136 commits into from

Conversation

edmund-h
Copy link
Contributor

@edmund-h edmund-h commented Mar 25, 2025

credit to @ElMariuso and @helloruhe for work on the original plague rework. unfortunatately this work was incomplete and breaks a lot of our lore content, so the merge was reverted as it blocked 1.15 release.

Changelog:

  • Changes the plague of undeath into an epidemic
  • Adds new events for characters who come in close contact with the plague
  • Contains fixes to the original work as well as long standing issues with the Scourge

Work still needed:

  • Fix Scourge Vassalization event such that the Scourge vassalizes rulers overtaken by the plague
  • Create events or effects that add troops to the Scorge in plagued counties (similar to original plague mechanic)
  • Remove outdated plague mechanics code
  • Fix start of Arthas events from Reign of Chaos and ensure that they fire consistently
  • Ensure that the invasion of Quel'Thalas and tainting of the Sunwell fire consistently
  • Reduce the plague type to Major from Apocalyptic; it is not a world-enveloping plague like Black Death
  • Ensure that plague events do not fire across water if possible

Tests:

  • Starting from 603 bookmark: Lordaeron should be plagued, Arthas activity should start soon after, all Arthas content should fire.
  • Starting from 583 bookmark: Scourge should appear after Dark Portal is closed. Plagues should begin progressively across areas of Northrend ruled by mortal races.
  • Starting from the 605 bookmark: Ensure that all relevant lore content is still working.
  • There are no errors in wc files in Documents\Paradox Interactive\Crusader Kings III\logs\error.log except portrait_decals.cpp:101
  • The mod takes less than 5.5 GB in the Task Manager (Windows)

edmund-h and others added 30 commits March 12, 2025 16:12
A little more cleaner looking code. Not much changes needed.
"01_hairstyles_base.txt" is a lot more complicated. I'll let the experts handle this
@edmund-h
Copy link
Contributor Author

edmund-h commented Mar 25, 2025

note to developers:

  • do not address the merge conflicts until work is ready to merge
  • please do not add new content unrelated to the scourge, the plague, or any region infected by the scourge in this branch

@edmund-h edmund-h marked this pull request as draft March 25, 2025 20:04
@edmund-h edmund-h added new feature ⭐ Involves adding new feature that affects game lore 📚 Comes from lore WIP 🚧 history 👑 Involves changing history bug fix 🔨 This pull request supposes bug fixes labels Mar 25, 2025
@edmund-h
Copy link
Contributor Author

edmund-h commented Apr 9, 2025

arthas activity start fixed on dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix 🔨 This pull request supposes bug fixes history 👑 Involves changing history lore 📚 Comes from lore new feature ⭐ Involves adding new feature that affects game WIP 🚧
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants