Update DROID_CONSTRUCT description to not include cyborgs

[aco4]

doc/js-objects.md incorrectly states that DROID_CONSTRUCT includes cyborg constructors. I fixed this, and was also planning on adding the updated droid types DROID_CYBORG_CONSTRUCT DROID_CYBORG_REPAIR and DROID_CYBORG_SUPER:

warzone2100/src/statsdef.h

Lines 37 to 54 in 79232da

	enum DROID_TYPE
	{
	DROID_WEAPON, ///< Weapon droid
	DROID_SENSOR, ///< Sensor droid
	DROID_ECM, ///< ECM droid
	DROID_CONSTRUCT, ///< Constructor droid
	DROID_PERSON, ///< person
	DROID_CYBORG, ///< cyborg-type thang
	DROID_TRANSPORTER, ///< guess what this is!
	DROID_COMMAND, ///< Command droid
	DROID_REPAIR, ///< Repair droid
	DROID_DEFAULT, ///< Default droid
	DROID_CYBORG_CONSTRUCT, ///< cyborg constructor droid - new for update 28/5/99
	DROID_CYBORG_REPAIR, ///< cyborg repair droid - new for update 28/5/99
	DROID_CYBORG_SUPER, ///< cyborg repair droid - new for update 7/6/99
	DROID_SUPERTRANSPORTER, ///< SuperTransport (MP)
	DROID_ANY, ///< Any droid. Used as a parameter for various stuff.
	};

But I came across #614 which seems to suggest that these newer droid types are intentionally excluded? So I didn't add them.

Mod

The following mod fails to preserve Cyborg Constructor templates

multiplay/scripts/mods/init.js:

namespace("OnlyTrucks_");

function OnlyTrucks_eventStartLevel() {
    enforce();
}

function OnlyTrucks_eventMenuManufacture() {
    enforce();
}

function OnlyTrucks_eventDesignQuit() {
    enforce();
}

function enforce() {
    enumTemplates(selectedPlayer).forEach(t => {
        if (t.droidType != DROID_CONSTRUCT) {
            removeTemplate(t.name);
        }
    });
}

While the following mod DOES preserve them:

...

function enforce() {
    enumTemplates(selectedPlayer).forEach(t => {
        if (t.droidType != DROID_CONSTRUCT  && t.droidType != 10) {
            removeTemplate(t.name);
        }
    });
}

[KJeff01]

It technically does. the wzapi combines them all into one shared type. If you enumDroid(x, DROID_CONSTRUCT) it will contain combat engineers and trucks. This goes for repairs and super cyborgs as well. Thus their droidType, as a droid object as far as the wzapi is concerned, will also show them as DROID_CONSTRUCT to scripts. Now, if someone wants to actually find the unique cyborg variants they will need to search for other methods like checking the droid components (which isn't super ideal).

What's probably really going on here, in your case, is that the function that looks at templates, enumTemplates(), is merely returning the type as defined in the template itself without considering this combined type behavior as used elsewhere in the wzapi. Unsurprisingly, this wasn't caught much earlier probably cause nobody tried using this particular function before (at least I haven't). I may be wrong on that as I didn't investigate this totally, but that would make the most sense to me.