-
Notifications
You must be signed in to change notification settings - Fork 204
Open
Labels
enhancementidealow-priorityIssues that aren't likely to be resolved soonIssues that aren't likely to be resolved soon
Description
Describe the bug
this->plugins_opt.set_callback([=] ()
{
/* reload when config reload has finished */
idle_reload_plugins.run_once([&] () { reload_dynamic_plugins(); });
});
Plugin reload/enable/disable will stop working after using set_option_values.
To Reproduce
Steps to reproduce the behavior:
def verify_required_wayfire_plugins():
required_plugins = {
"stipc",
"ipc",
"ipc-rules",
"resize",
"window-rules",
"wsets",
"session-lock",
"wm-actions",
"move",
"vswitch",
"grid",
"place",
"scale",
}
enabled_plugins = sock.get_option_value("core/plugins")["value"].split()
for plugin_name in required_plugins:
if plugin_name not in enabled_plugins:
enabled_plugins.append(plugin_name)
sock.set_option_values({"core/plugins": " ".join(enabled_plugins)})
verify_required_wayfire_plugins()
disable or enable a plugin in wayfire.ini
Expected behavior
plugin-loader should at least LOGE the reason why the plugins can't reload/enable/disable.
Suggestion
reload_config_signal somewhere in set_config_options will set a callback LOGI with the options that can't be modified by wayfire.ini
Why consider the Suggestion
It took me a while to find the issue, others might face the same problem without knowing the cause, some others could set random plugins options and complain later why these options is not changing through wayfire.ini.
Metadata
Metadata
Assignees
Labels
enhancementidealow-priorityIssues that aren't likely to be resolved soonIssues that aren't likely to be resolved soon