Skip to content

Incompatible with Magewire; allow route exclusions #12

@rhoerr

Description

@rhoerr

This is a really helpful module, but the comments it adds to output can cause problems for some JS and other systems.

One in particular is Magewire, which relies on one parent node in the HTML sections.

I suggest adding a setting to exclude controller routes or URLs from processing, so that we could have this module enabled except on requests to magewire/, or my/custom/ajax, or other routes as appropriate.

An alternative might be stripping top-level comments from output, but that would certainly cause other issues, and wouldn't necessarily solve all incompatibilities either.

Thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions