bug under clang 21/22. Cannot use C string for literal array

[trcrsired]

clang -O2 -DNDEBUG --target=wasm32-wasip1 -fno-trapping-math -Wall -Wextra -Werror -Wno-null-pointer-arithmetic -Wno-unused-parameter -Wno-sign-compare -Wno-unused-variable -Wno-unused-function -Wno-ignored-attributes -Wno-missing-braces -Wno-ignored-pragmas -Wno-unused-but-set-variable -Wno-unknown-warning-option -mthread-model single -Ilibc-bottom-half/cloudlibc/src -isystem "/home/cqwrteur/toolchains_build/wasi-libc/sysroot/include/wasm32-wasip1" -Ilibc-top-half/musl/src/include -Ilibc-top-half/musl/src/internal -Ilibc-top-half/musl/arch/wasm -Ilibc-top-half/musl/arch/generic -Ilibc-top-half/headers/private -Wno-parentheses -Wno-shift-op-parentheses -Wno-bitwise-op-parentheses -Wno-logical-op-parentheses -Wno-string-plus-int -Wno-dangling-else -Wno-unknown-pragmas -MD -MP -o build/wasm32-wasip1/libc-top-half/musl/src/stdio/vwprintf.o -c libc-top-half/musl/src/stdio/vwprintf.c
libc-top-half/musl/src/stdio/vfprintf.c:170:2: error: initializer-string for character array is
      too long, array size is 16 but initializer has size 17 (including the null terminating character); did you mean
      to use the 'nonstring' attribute? [-Werror,-Wunterminated-string-initialization]
  170 |         "0123456789ABCDEF"
      |         ^~~~~~~~~~~~~~~~~~
1 error generated.

[sbc100]

This looks like a false positive and musl really does want to create a non-null-terminated string here.

I suggest we simply add -Wno-unterminated-string-initialization to the musl build.

[trcrsired]

This looks like a false positive and musl really does want to create a non-null-terminated string here.

I suggest we simply add -Wno-unterminated-string-initialization to the musl build.

better to report it to musl upstream to use char [16] = {'0','1',....'f'} directly. C style string array always has a null terminator

[sbc100]

I don't know if you will get much traction with musl upstream for fixing what seems to be a false positive.

Also, the musl release cylce is very long so even if you landed it there it could be months/years before a release includes it.

Bettter to suppress these warnings I think, musl was never designed to be build with -Wall -Wextra like we do.

[yamt]

clang -O2 -DNDEBUG --target=wasm32-wasip1 -fno-trapping-math -Wall -Wextra -Werror -Wno-null-pointer-arithmetic -Wno-unused-parameter -Wno-sign-compare -Wno-unused-variable -Wno-unused-function -Wno-ignored-attributes -Wno-missing-braces -Wno-ignored-pragmas -Wno-unused-but-set-variable -Wno-unknown-warning-option -mthread-model single -Ilibc-bottom-half/cloudlibc/src -isystem "/home/cqwrteur/toolchains_build/wasi-libc/sysroot/include/wasm32-wasip1" -Ilibc-top-half/musl/src/include -Ilibc-top-half/musl/src/internal -Ilibc-top-half/musl/arch/wasm -Ilibc-top-half/musl/arch/generic -Ilibc-top-half/headers/private -Wno-parentheses -Wno-shift-op-parentheses -Wno-bitwise-op-parentheses -Wno-logical-op-parentheses -Wno-string-plus-int -Wno-dangling-else -Wno-unknown-pragmas -MD -MP -o build/wasm32-wasip1/libc-top-half/musl/src/stdio/vwprintf.o -c libc-top-half/musl/src/stdio/vwprintf.c
libc-top-half/musl/src/stdio/vfprintf.c:170:2: error: initializer-string for character array is
      too long, array size is 16 but initializer has size 17 (including the null terminating character); did you mean
      to use the 'nonstring' attribute? [-Werror,-Wunterminated-string-initialization]
  170 |         "0123456789ABCDEF"
      |         ^~~~~~~~~~~~~~~~~~
1 error generated.

does your source have #584 ?

[yamt]

C style string array always has a null terminator

it's wrong.

iirc, the warning is about C++ compatibility. i don't think it's important for us. (or musl)