Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aquarium normal maps load in a different way depending on browser (artifacts on MS Edge) #24

Open
Oletus opened this issue Aug 14, 2018 · 2 comments

Comments

@Oletus
Copy link
Contributor

Oletus commented Aug 14, 2018

It seems as if color space handling of loaded images differs between MS Edge and other browsers. This causes normal maps to be distorted on MS Edge. The fix for this according to the spec would be setting UNPACK_COLORSPACE_CONVERSION_WEBGL to NONE, but unfortunately MS Edge doesn't implement that at the moment. Another possible fix would be to decode the normal map PNG files in JS.

@greggman
Copy link
Contributor

greggman commented Aug 14, 2018 via email

@Oletus
Copy link
Contributor Author

Oletus commented Aug 14, 2018

That's reasonable - setting UNPACK_COLORSPACE_CONVERSION_WEBGL still needs to be added to tdl once Edge is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants