"only one file allowed" on Linux + Firefox/Chrome

[janjan]

Hi, thanks for your awesome tool!

After upgrading my PC you tool refused to accept pngs and svgs via drag'n'drop in Firefox and Chrome on Linux + KDE Plasma 6!

After a lot of head scratching and debugging I figured out that this problem is unrelated to your tool and that the real problems stems from the fact that my Linux switched from using X11 to Wayland. If you search for "Wayland firefox" you come across bugreports like this:

https://bugs.kde.org/show_bug.cgi?id=484018

KDE Plasma in Wayland does not support Drag and Drop operations from Dolphin to Chromium (and Firefox).

So there is basically nothing you can do on your side to fix it but I still decided to create this issue so that other people might find this report

(well, you could actually improve the error message by adding some additional code in onDragEvents() in /src/voronoi_app.js you can check if event.dataTransfer exist. If it is missing then there is a problem with the drag'n'drop functionality of your browser and you can alert with a better error message. But i am not sure if it is worth the trouble because hopefully this issue will be fixed in the next few weeks/months)

[wassfila]

@janjan thank you for your positive feedback about this tool and your help on working around this issue.
I did what you suggested in the referred to commit, I did not test it nor deploy it though.
Broader browser compatibility is indeed something valuable but also not that easy :)
I leave this open for some time, as open issue might be easier to find, then after some time I'll close it as the notification alert is now already implemented.

[janjan]

Hi, I just checked you code and I think it might be better to put the alert box with the new message like this:

if(event.type == "drop"){
   if(!event.dataTransfer){
      alert("Browser support issue, 'event.dataTransfer' does not exist")
   } else if(event.dataTransfer.files.length != 1){
      alert("only one file allowed");
      console.log(event.dataTransfer.files);
      return;
   } else {
      that.load_dropped_file(event.dataTransfer.files[0]);
   }
};

if you leave it right at the start of the onDragEvents function it will be triggered several times if the user is dragging files and then they will see several alert boxes

[wassfila]

@janjan sure, I can updated to be as you suggested, but I give you some time if you'd like to PR this repo, that way you'd be a contributor ;)