Readiness and Liveness probes

[Mart-Kuc]

Describe the issue

Hello,

Due to changes in this commit the values for the Readiness and Liveness probes are not being applied, and we are unable to set or override the new/default values.

Both probes still expect the values to be provided within a with statement as part of the code logic.

I already tried

• I've read and searched the documentation.
• I've searched for similar filed issues in this repository.

Steps to reproduce the behavior

1. helm template -f values.yaml . > test.yaml
   Open test.yaml and values for readiness and liveness probes doesn't exist even they are bot defined in values.yaml
   

Expected behavior

We should see values which are defined in values.yaml

Screenshots

No response

Exception traceback

No response

Additional context

From my point of view this PR doesn't make sense. Because you replaced with statement with an if condition, but both serve the same purpose. If you have if condition or if you have with statement they both do same things. with statement will not be templated in case that you set empty bracket ({}) as the value.

See example:

So my suggestion is revert/remove this one PR

However, if you prefer to keep these changes, I have created a separate PR with the necessary fixes.

[st-myk]

@Mart-Kuc , that's totally my fault, I opted for if condition to have a cleaner look in the final configuration if you don't want to use the probes. Without {}.

[nijel]

Fixed by #467, thanks.

[github-actions]

The issue you have reported is now resolved. If you don’t feel it’s right, please follow its labels to get a clue for further steps.

• In case you see a similar problem, please open a separate issue.
• If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.