[Bug] Invalid float literal

[Antonio225t]

Operating System

Linux

What's the issue you encountered?

I'm on ArchLinux, KDE Plasma 6.5.3 and basically I had the predefined lang numbers with comma instead of with point (my system accepted "1,0" to be a float instead of "1.0" and so did ImHex because of this). If I type something like:

std::print(1.2);

In the pattern editor it errors out saying:

Invalid float literal: 1.2

But, of course, I can't make the float be "1,2" because that's a completely different syntax. I believe that this is a bug and at least on the pattern editor we should use the pattern syntax "1.2" instead of the system's default floating number which can cause conflict with the pattern syntax.

How can the issue be reproduced?

To reproduce:

1. Change your system language to have floats with commas instead of points;
2. Open ImHex and type float Variable = 2.1; and run the code (this should be enough to cause the invalid float literal error).

ImHex Version

1.37.4

ImHex Build Type

• Nightly or built from sources

Installation type

AUR

Additional context?

The only fix as for now is to change your system settings to recognize numbers with points (1.0) to be floats and not numbers with commas (1,0) to be floats

[paxcut]

I changed the regional settings so that numbers are displayed using commas instead of points in windows 10 and it doesn't affect ImHex so that the test case suggested works fine. In the code the error "invalid float literal" is created when using std::strtod to convert the string into a floating point value. std::strtod is not changing results based on my regional settings for displaying numbers.

If changing system settings in your OS affects the format of numbers in ImHex then it should be changing it to accept the new format type so if 1.2 is an invalid floating point literal then 1,2 should be accepted as valid. What does it display when you type the following?

std::print("{}",1/2f);

I get this

I: 0.5

but all numbers displayed by my os use commas, but the apps still behave like before i changed the settings.

[WerWolv]

This actually comes from the pattern language using std::strtod() instead of std::from_chars() because some distros didn't support it yet. stdtod is affected by locale now.

Could you try with the latest nightly build maybe? I believe I started setting the locale to the standard C UTF8 variant explicitly sometime since the previous release version so it shouldn't be an issue anymore. Although I would like to move back to from_chars again eventually

[Antonio225t]

I changed the regional settings so that numbers are displayed using commas instead of points in windows 10 and it doesn't affect ImHex so that the test case suggested works fine. In the code the error "invalid float literal" is created when using std::strtod to convert the string into a floating point value. std::strtod is not changing results based on my regional settings for displaying numbers.

If changing system settings in your OS affects the format of numbers in ImHex then it should be changing it to accept the new format type so if 1.2 is an invalid floating point literal then 1,2 should be accepted as valid. What does it display when you type the following?

std::print("{}",1/2f);

I get this

I: 0.5

but all numbers displayed by my os use commas, but the apps still behave like before i changed the settings.

To me the error is shown by using std::print and while being called in an if statement (like if (float_value == 2.2) <-- this caused that error on me)

[paxcut]

the reason I don't get an error is because it isn't enough to just change the settings for displaying floating point numbers using commas, you need to change the locale to one using the format you describe. Only then std::strtod() is affected by the change and the error will occur everywhere std::strtod() is used to read floats. I didn't change my locale so the error doesn't appear.