Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French and German Menus #22

Open
TeoTwawki opened this issue Dec 16, 2015 · 2 comments
Open

French and German Menus #22

TeoTwawki opened this issue Dec 16, 2015 · 2 comments

Comments

@TeoTwawki
Copy link
Contributor

So I did not realize SE dropped French and German support from the client and all the French and German dats I see are leftovers and newer content's alt language dats exist but are empty (they left placeholder dats all over). At this point I don't think its worth bothering to find the few that have actual dialog strings still.

More than a 3rd of SoA and none of Rhapsodies have no French or German strings, and some of the older strings are no longer being update when the English and Japanese are.

Perhaps its for the best to drop those menu's out of polutils entirely? I can either:

  1. try to fill in what exists and trim off what does not
  2. leave sections greyed out
  3. remove it all entirely.

Let me know and I can prep a pull request soon.

@alphaONE2
Copy link
Member

The way it's always been handled in the past is to leave the references to old .dats in the menu, but mark them as old or out of date. See the spell lists for an example. I think the best option is to just mark the top FR and DE sub-menus as unused. There's no point in filling out all of missing stuff, just remove any menu items if the .dats don't exist.

@z16
Copy link
Member

z16 commented Dec 24, 2015

I don't have any strong feelings towards this issue, so whatever @iryoku says.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants