Skip to content

Discussion: handling of PHP version / os dependent results #96

Open
@reimic

Description

@reimic

I've noticed that the RunWordPressInstallerStepRunner returns different success messages for different PHP versions.

For PHP <= 7.3 it returns:
#!/usr/bin/env php\n Success: WordPress installed successfully.

And for PHP > 7.3 it returns:
Success: WordPress installed successfully.

That's just a small / funny wp-cli quirk and it is quite easy to handle, yet it begs a crucial question - should we take the responsibility of delivering unified responses for all PHP / os versions?

Keeping huge ambitions for playground and blueprints in mind, not taking the burden at code level will inevitably push it to support / end users. Although it may look like a nitpick today, it won't take long until this will start causing real-life problems. So, I'd recommend we include a design principle to... care about this... I guess.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions