Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: handling of PHP version / os dependent results #96

Open
reimic opened this issue Mar 30, 2024 · 1 comment
Open

Discussion: handling of PHP version / os dependent results #96

reimic opened this issue Mar 30, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@reimic
Copy link
Collaborator

reimic commented Mar 30, 2024

I've noticed that the RunWordPressInstallerStepRunner returns different success messages for different PHP versions.

For PHP <= 7.3 it returns:
#!/usr/bin/env php\n Success: WordPress installed successfully.

And for PHP > 7.3 it returns:
Success: WordPress installed successfully.

That's just a small / funny wp-cli quirk and it is quite easy to handle, yet it begs a crucial question - should we take the responsibility of delivering unified responses for all PHP / os versions?

Keeping huge ambitions for playground and blueprints in mind, not taking the burden at code level will inevitably push it to support / end users. Although it may look like a nitpick today, it won't take long until this will start causing real-life problems. So, I'd recommend we include a design principle to... care about this... I guess.

@reimic reimic added the enhancement New feature or request label Mar 30, 2024
@adamziel
Copy link
Collaborator

adamziel commented Apr 2, 2024

I'd like to understand what's the root cause behind the shebang line being printed on PHP <= 7.3 before making any decisions here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants