Skip to content

Commit 914f543

Browse files
authored
Emulate reduced-motion in e2e tests (#34132)
1 parent 3e645c4 commit 914f543

File tree

7 files changed

+10
-31
lines changed

7 files changed

+10
-31
lines changed

.github/workflows/end2end-test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ jobs:
3838
- name: Npm install and build
3939
run: |
4040
npm ci
41-
FORCE_REDUCED_MOTION=true npm run build
41+
npm run build
4242
4343
- name: Install WordPress
4444
run: |

packages/compose/src/hooks/use-reduced-motion/index.js

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -3,23 +3,12 @@
33
*/
44
import useMediaQuery from '../use-media-query';
55

6-
/**
7-
* Whether or not the user agent is Internet Explorer.
8-
*
9-
* @type {boolean}
10-
*/
11-
const IS_IE =
12-
typeof window !== 'undefined' &&
13-
window.navigator.userAgent.indexOf( 'Trident' ) >= 0;
14-
156
/**
167
* Hook returning whether the user has a preference for reduced motion.
178
*
189
* @return {boolean} Reduced motion preference value.
1910
*/
20-
const useReducedMotion =
21-
process.env.FORCE_REDUCED_MOTION || IS_IE
22-
? () => true
23-
: () => useMediaQuery( '(prefers-reduced-motion: reduce)' );
11+
const useReducedMotion = () =>
12+
useMediaQuery( '(prefers-reduced-motion: reduce)' );
2413

2514
export default useReducedMotion;

packages/e2e-tests/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22

33
## Unreleased
44

5+
### New Features
6+
7+
- Emulate `prefers-reduced-motion: reduce` [#34132](https://github.com/WordPress/gutenberg/pull/34132).
8+
59
## 2.4.0 (2021-07-29)
610

711
### New Features

packages/e2e-tests/config/setup-test-framework.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -240,6 +240,9 @@ beforeAll( async () => {
240240
await trashAllPosts( 'wp_block' );
241241
await setupBrowser();
242242
await activatePlugin( 'gutenberg-test-plugin-disables-the-css-animations' );
243+
await page.emulateMediaFeatures( [
244+
{ name: 'prefers-reduced-motion', value: 'reduce' },
245+
] );
243246
} );
244247

245248
afterEach( async () => {

packages/e2e-tests/specs/widgets/editing-widgets.test.js

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -56,23 +56,10 @@ describe( 'Widgets screen', () => {
5656
beforeAll( async () => {
5757
// TODO: Ideally we can bundle our test theme directly in the repo.
5858
await activateTheme( 'twentytwenty' );
59-
// Reduced motion is needed to immediately show and dismiss the snackbars.
60-
await page.emulateMediaFeatures( [
61-
{
62-
name: 'prefers-reduced-motion',
63-
value: 'reduce',
64-
},
65-
] );
6659
await deleteAllWidgets();
6760
} );
6861

6962
afterAll( async () => {
70-
await page.emulateMediaFeatures( [
71-
{
72-
name: 'prefers-reduced-motion',
73-
value: 'no-preference',
74-
},
75-
] );
7663
await activateTheme( 'twentytwentyone' );
7764
} );
7865

tools/webpack/shared.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,6 @@ const plugins = [
7171
'process.env.GUTENBERG_PHASE': JSON.stringify(
7272
parseInt( process.env.npm_package_config_GUTENBERG_PHASE, 10 ) || 1
7373
),
74-
'process.env.FORCE_REDUCED_MOTION': JSON.stringify(
75-
process.env.FORCE_REDUCED_MOTION
76-
),
7774
} ),
7875
new DependencyExtractionWebpackPlugin( { injectPolyfill: true } ),
7976
mode === 'production' && new ReadableJsAssetsWebpackPlugin(),

typings/gutenberg-env/index.d.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
interface Environment {
22
NODE_ENV: unknown;
3-
FORCE_REDUCED_MOTION: boolean | undefined;
43
}
54
interface Process {
65
env: Environment;

0 commit comments

Comments
 (0)