Skip to content

Commit b317901

Browse files
committed
Remove solved TODOs
1 parent ccb6839 commit b317901

File tree

1 file changed

+0
-22
lines changed
  • packages/components/src/ui/radix-dropdown

1 file changed

+0
-22
lines changed

packages/components/src/ui/radix-dropdown/index.tsx

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -28,28 +28,6 @@ import type {
2828
DropdownSubMenuTriggerProps,
2929
} from './types';
3030

31-
// Observations / Questions:
32-
// - is it enough on the larger components to have only one forwarded ref?
33-
// If we have only one, should it be to the "root", the "trigger", or the "content"?
34-
// - Should we be consistent in using the same value for the `asChild` prop on:
35-
// - trigger
36-
// - content
37-
// - sub trigger
38-
// - sub content
39-
// - Should we allow customizing the `asChild` prop on trigger and content?
40-
// - Props & customisability:
41-
// - Which props should we expose?
42-
// - Should props be "namespaced" for each subcomponent?
43-
// - We should probably explicitly `Pick<>` every prop that we want to expose
44-
// - Subtrigger arrow:
45-
// - Should it always be there (ie. an internal implementation)?
46-
// - Should we just expect that the the consumers handle it themselves?
47-
// - Should we expose it as a separate component that consumers could use?
48-
// - DropdowmMenuItem icon prop:
49-
// - added to mirror previous menu item component
50-
// - should we expect consumers to provide this directly with children?
51-
// - should we expose prefix / suffix to help?
52-
// - Props: should we export HTML-inherited props? (e.g styles, classnames, hidden, etc..)
5331
export const DropdownMenu = ( {
5432
// Root props
5533
defaultOpen,

0 commit comments

Comments
 (0)